Let a package and a theme link to their license terms - #19
Merged
Conversation
`ScenePackage` gained `License` and `LicenseUrl`, and `Theme` gained the matching `LicenseUrl` to go with the `License` it already carried. A license name on its own does not tell an author what they are taking on. "PrimeUI Community / Commercial" answers nothing about whether they qualify for the free tier or owe a fee - the link is the part that does, so the model carries it rather than making someone go and search. This matters now because it stopped being uniform. Every package here was MIT until PrimeReact 11 relicensed under PrimeTek's commercial PrimeUI, so `Cratis.PrimeReact` and the themes built on its presets now point at https://primeui.dev/licenses/community while everything else points at ours. A package picker can show the difference at the moment someone is choosing, instead of leaving it to a banner in production. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
einari
added
screen
RCS1232 wants the param documentation in the order the parameters are declared. LicenseUrl was appended after Description to keep positional construction working, but its doc was written next to License, which reads better and broke the build. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EGM8pbSNm2nS8KoKCpKNui
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
ScenePackagegainedLicenseandLicenseUrl;Themegained theLicenseUrlto go with theLicenseit already carried. A license name on its own does not tell an author what they are taking on — "PrimeUI Community / Commercial" says nothing about whether they qualify for the free tier or owe a fee. The link is the part that answers that, so the model carries it.Changed
Cratis.PrimeReactand every theme built on PrimeTek's presets now point at the PrimeUI Community license; every other package points at ours. This stopped being uniform when PrimeReact 11 relicensed from MIT, and a package picker can now show the difference at the moment someone is choosing rather than leaving it to a banner in production.🤖 Generated with Claude Code