Skip to content

Let OIDC handle npm auth (drop setup-node placeholder token) #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MikeAlhayek merged 1 commit into from
Sep 14, 2026
Merged

Let OIDC handle npm auth (drop setup-node placeholder token) #191

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions .github/workflows/publish_npm.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,8 +115,11 @@ jobs:
if: steps.check-publish.outputs.should-publish == 'true'
with:
node-version: "20"
registry-url: "https://registry.npmjs.org"
scope: "@crestapps"
# Deliberately no registry-url/scope: those make setup-node write an
# .npmrc with `_authToken=${NODE_AUTH_TOKEN}` and export a placeholder
# NODE_AUTH_TOKEN. npm would then treat that placeholder as credentials
# and skip OIDC, so trusted publishing never runs. The registry comes
# from publishConfig.registry in the package's package.json instead.

- name: Update npm for trusted publishing
if: steps.check-publish.outputs.should-publish == 'true'
Expand All @@ -135,6 +138,8 @@ jobs:
working-directory: src/Resources/CrestApps.AI.Resources
# No NODE_AUTH_TOKEN: authentication is handled by OIDC trusted publishing.
run: |
node -v
npm -v
if [ "${{ steps.check-publish.outputs.release-mode }}" = "true" ]; then
VERSION="${{ steps.check-publish.outputs.release-version }}"
DIST_TAG="latest"
Expand Down
Loading