Offset preview run number to stay ahead of pre-merge versions - #192
Merged
Merged
Conversation
Merging the two publish workflows into publish_npm.yml reset GitHub's run_number to 1, so the first OIDC publish produced 2.0.0-preview.5 -- lower than the 2.0.0-preview.175 the old workflow had reached. Add 180 to the run number so the .N suffix stays monotonic and above the last published preview. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #191. OIDC trusted publishing now works end-to-end 🎉 — but merging the two workflows into
publish_npm.ymlreset GitHub'srun_numberto 1, so the first successful publish was2.0.0-preview.5, which is lower than the2.0.0-preview.175the old workflow had reached (.5 < .175in semver).Add
180to the run number for preview builds so the.Nsuffix stays monotonically increasing and above the last published preview. The next preview publish will be2.0.0-preview.18N(run_number + 180), restoring correct ordering; the stray.5stays in the registry but is superseded on thepreviewdist-tag by the next publish.Release versions are unaffected — they come from the git tag, not the run number.
🤖 Generated with Claude Code