feat(wallets): regenerate OpenAPI types with quorum boundary shapes#1986
Open
panosinthezone wants to merge 3 commits into
Open
feat(wallets): regenerate OpenAPI types with quorum boundary shapes#1986panosinthezone wants to merge 3 commits into
panosinthezone wants to merge 3 commits into
Conversation
- Refresh openapi.json with the quorum boundary contract (create-side config.recovery + quorum adminSigner variant, approval-side discriminated union with quorumApprovals). - Throw QuorumSignerNotSupportedError when a pending approval belongs to a quorum signer; real quorum handling lands with the approval-loop ticket. - Re-add the `code` property to WalletV1Alpha2ErrorDTO, dropped by the preview-env spec (predates the backend change that added it). WAL-11289 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 94c12b6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Prompt To Fix All With AIFix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
packages/wallets/src/utils/errors.ts:288-289
`QuorumSignerNotSupportedError` is thrown by `approve()`, `send()`, and any path that calls `approveTransactionInternal`/`approveSignatureInternal`, but it is absent from the `WalletError` union type. TypeScript consumers narrowing on `WalletError` will not handle this case, and any `catch (e: WalletError)` guard silently misses it. `DeviceSignerNotSupportedError` — the analogous class added earlier — is already in the union, so this looks like an oversight in the same addition.
```suggestion
| DeviceSignerNotSupportedError
| QuorumSignerNotSupportedError
| InvalidMessageFormatError
```
Reviews (1): Last reviewed commit: "feat(wallets): regenerate OpenAPI types ..." | Re-trigger Greptile |
Contributor
|
Reviews (2): Last reviewed commit: "using latest schema" | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WAL-11289
Refreshes
packages/wallets/src/openapi.jsonfrom crossbit-main #27842 so the generated types pick up the quorum boundary contract:config.recovery+{ type: "quorum", threshold, signers[] }adminSigner variant.quorumApprovalsprogress).Until the approval-loop ticket lands real quorum handling,
approve()throws aQuorumSignerNotSupportedErrorwhen a pending approval belongs to a quorum signer.Also re-adds the
codeproperty toWalletV1Alpha2ErrorDTO(used to detectDEVICE_SIGNER_NOT_SUPPORTED), which the preview-env spec predates. The spec should be re-pulled from staging/main after #27842 merges.🤖 Generated with Claude Code