chore: repo hygiene (.gitignore + untrack node_modules + dedupe pg-hstore)#33
Open
CryptoJones wants to merge 1 commit into
Open
chore: repo hygiene (.gitignore + untrack node_modules + dedupe pg-hstore)#33CryptoJones wants to merge 1 commit into
CryptoJones wants to merge 1 commit into
Conversation
…upe pg-hstore Closes #27, closes #28. This is a one-time cleanup. No runtime behavior changes. - Add a standard Node .gitignore (node_modules/, *.log, .env, dist/, coverage/, editor noise). The repo previously had no .gitignore at all, which is how the 5176-file node_modules tree and the 197 KB npm-debug.log ended up tracked. - git rm -r --cached node_modules + git rm --cached npm-debug.log to stop tracking the already-committed files. Files stay on disk; only git's index is updated. Fresh clones recreate them via npm install. - package.json: remove the duplicate "pg-hstore" key. The file previously listed pg-hstore twice (^2.3.4 and ^2.3.3). JSON parsers keep the last entry, so the effective pin was the lower ^2.3.3. Kept ^2.3.4. - package.json: fix `main` to point at the actual entry point (server.js, not the nonexistent index.js). Drive-by because it's in the same file and the same shape of bug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #27, closes #28.
Summary
One-time cleanup. Three small fixes, zero runtime behavior change.
.gitignoreadded coveringnode_modules/,*.log,.env,.env.*(with a!.env.examplecarve-out),dist/,coverage/, common editor and OS noise. The repo previously had no.gitignoreat all, which is how the 5,176-filenode_modulestree and the 197 KBnpm-debug.logended up tracked in the first place.Untracked the already-committed dependency tree and log file:
Files stay on disk; only git's index is updated. Fresh clones recreate
node_modules/vianpm install.package.jsonpg-hstorededup. The file listedpg-hstoretwice (^2.3.4and^2.3.3). JSON parsers keep only the last duplicate key, so the effective pin was the lower^2.3.3. Kept^2.3.4.Drive-by:
package.json:mainpointed at the nonexistentindex.js. Changed toserver.js, the actual entry point.Diff shape
The line count is intimidating but it is entirely
node_modules/*getting unstaged — no application code was touched beyond the two-linepackage.jsonchange.Acceptance criteria
.gitignoreexists withnode_modules/,*.log,.env, etc.git ls-files | grep -c node_modules/→ 0git ls-files | grep npm-debug.log→ (empty)npm install && node server.jsworks on a fresh clone (verified locally).pg-hstoreline inpackage.json.package.json:mainmatches the actual entry point.Proudly Made in Nebraska. Go Big Red! 🌽 https://xkcd.com/2347/