fix: wire lifespan into FastMCP and remove asyncio.sleep placeholder

[mkostersitz]

Problem

lifespan() was defined but never passed to FastMCP():

# before
mcp = FastMCP(name="Android-MCP", instructions=instructions)

This meant lifespan was dead code — silently ignored on every startup. Any future initialization or shutdown logic added there would never run.

Additionally, the body of lifespan contained await asyncio.sleep(1) with a comment saying "Simulate startup latency" — a debugging artefact that added a 1-second delay to every server start for no reason.

Fix

• Pass lifespan=lifespan to the FastMCP constructor
• Remove the asyncio.sleep(1) placeholder
• Drop the now-unused asyncio import

# after
mcp = FastMCP(name="Android-MCP", instructions=instructions, lifespan=lifespan)

Notes

The upstream code is already ahead of the version distributed via the Claude extension marketplace (which still had the original eager-connect crash). This is a small but real correctness fix — without it the lifespan hook is inert and can't be relied on for any future startup work (e.g. pre-warming the ADB connection, logging server info, etc.).

🤖 Generated with Claude Code

[qodo-code-review]

Review Summary by Qodo

Wire lifespan into FastMCP and remove sleep placeholder

🐞 Bug fix

Walkthroughs

Description

• Wire lifespan hook into FastMCP constructor
• Remove unused asyncio.sleep(1) placeholder
• Drop now-unused asyncio import

Diagram

flowchart LR
  A["lifespan function<br/>defined but unused"] -->|"wire via<br/>lifespan= kwarg"| B["FastMCP constructor<br/>receives lifespan"]
  C["asyncio.sleep(1)<br/>placeholder"] -->|"remove"| D["Clean startup<br/>no delay"]
  E["asyncio import<br/>unused"] -->|"drop"| F["Reduced imports"]

Loading

File Changes

1. src/android_mcp/__main__.py 🐞 Bug fix +1/-3

Wire lifespan hook and remove sleep placeholder

• Removed unused asyncio import
• Removed await asyncio.sleep(1) placeholder from lifespan() function
• Passed lifespan=lifespan parameter to FastMCP constructor
• Lifespan hook now properly wired for startup/shutdown logic

src/android_mcp/main.py

---

[qodo-code-review]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review