test(network): cover outbound proxy/TLS config, resolver and replay routing - #109
Open
lorenzozanee wants to merge 1 commit into
Open
test(network): cover outbound proxy/TLS config, resolver and replay routing#109lorenzozanee wants to merge 1 commit into
lorenzozanee wants to merge 1 commit into
Conversation
…outing The outbound proxy/TLS feature (CyberStrikeus#102) shipped without tests. Add coverage for the network config schema and secret redaction, the Network resolver (forHost/forUrl, bypass matching, per-host client certificates, TLS precedence) and replay routing through a real local proxy.
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the missing test coverage for the outbound proxy/TLS feature from #102: the
networkconfig schema (including secret redaction), theNetworkresolver (forHost/forUrl, bypass matching, per-host client certificates, TLS precedence), and replay routing through a real local proxy.The hackbrowser side of #102 reuses the same
Networklayer throughforBrowser()(covered here: proxy server/bypass, SOCKS+auth refusal, certificate-error handling); the browser itself is exercised end-to-end in the existing crawler tests, so no separate hackbrowser wiring test was added.Fixes #102
Type of change
Security impact
How did you verify it works?
bun test test/network/network.test.tsfrompackages/cyberstrike→ 52 pass;bun turbo typecheckclean. The wire tests spin up local loopback origin + proxy servers, no external network needed.Checklist
bun turbo typecheckpasses