fix(tui): dedupe concurrent bootstraps to prevent first-run freeze - #110
Open
lorenzozanee wants to merge 1 commit into
Open
fix(tui): dedupe concurrent bootstraps to prevent first-run freeze#110lorenzozanee wants to merge 1 commit into
lorenzozanee wants to merge 1 commit into
Conversation
During first-time provider setup the disposed server instance fires server.instance.disposed, which triggers sync.bootstrap() from the SSE handler while the provider dialog awaits its own sync.bootstrap() right after instance.dispose(). The two runs overlap and race the global store transitions. Wrap bootstrap in a singleflight helper so concurrent calls share one in-flight promise; the guard clears on settle so later disposed/reload events still re-bootstrap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #66.
During first-time provider setup, two bootstrap triggers fire concurrently:
dialog-provider.tsxawaitssync.bootstrap()right afterinstance.dispose()(4 call sites)server.instance.disposedhandler callsbootstrap()(packages/cyberstrike/src/cli/cmd/tui/context/sync.tsx:301)The disposed event is emitted before the dispose response returns, so both runs overlap on the first-run auth flow and race the global store transitions. This wraps
bootstrapin a newsingleflighthelper (packages/cyberstrike/src/util/singleflight.ts) so concurrent calls share one in-flight promise. The guard clears on settle, so later disposed/reload events still trigger a fresh bootstrap. Single, non-overlapping bootstraps behave exactly as before.Type of change
Security impact
How did you verify it works?
packages/cyberstrike/test/util/singleflight.test.tscover the dedup contract: concurrent calls share one execution, re-execution after the promise settles, rejection propagates to all callers and clears the guard, and sequential calls each run.bun test test/util/passes (28 tests) andbun test test/cli/tui/passes.bun run typecheck(tsgo) passes inpackages/cyberstrike.Checklist
bun turbo typecheckpasses