fix(directory): make seller publication restart-safe - #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Makes the Community Directory
/registerseller flow safe to use against the live Demos StorageProgram contract. New listings use the SDK #70 next-nonce/empty-salt address convention, and an ambiguous or interrupted broadcast can be resumed without creating or overwriting another immutable listing version.Changes
dacs:v1derivation helper for existing fallback readers; no SDK pin, indexer, gateway, or Standard change is included.Safety contract
Validation
npm run typechecknpm test— 201 passedCI=1 npm run test:e2e -- --workers=1— 16 passednpm run buildpassedgit diff --checkpassedabsent; nonce RPC returned HTTP/RPC 200 with a safe nonnegative valuestor-225d925e0427753fdea2a5e5ac040d58e7c47ac3; legacy salt remains distinctSubmission checklist
reference-implementations/dacs-directory/