Align Directory listing admission with current SDK - #85
Draft
randomblocker wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dacs-sdkmain (2d53f03778189b8f36573720e68d8743a94e4f2b) and replace the permissive current Listing parser with the SDK's normative validator and signature APIsWhy
The live Directory accepted current-looking Listings whose
offering.deliverable.verificationMethodwas a string, while the current Standard and SDK require a registered structured variant. Those candidates could be discovered but were rejected by an independent SDK buyer before payment.The Directory also pinned an SDK revision hundreds of commits behind main and duplicated enough Listing validation to drift from the normative shape.
Impact
After deployment and reindex, malformed current Listings are observed but excluded from the active catalog with stable public-safe diagnostics. New attested-payload Listings produced by the Directory use
{ "kind": "self-signed" }.The three existing x402 Listings in the regression fixture remain excluded until their sellers republish conforming versions. This PR does not loosen the SDK, republish artifacts, or change gateway/external-buyer custody.
SDK packaging note
The current SDK top-level barrel statically re-exports optional rail and substrate adapters, so it is not browser-bundle-safe without unrelated peers. Community imports the public verification names through one isolated compatibility module until the SDK publishes a browser-safe verification subpath.
Validation
npm test— 203 passednpm run typechecknpm run buildnpm run test:e2e— 16 passedbash -n scripts/setup-sdk.shgit diff --check