Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #559.
Fixes historical evidence recall leaking across conversation branches after retrying or editing a message.
This change:
HistoricalMessageScope, based on the immutableparent_message_idancestor chain.INparameter lists.LIMIT, preventing newer sibling evidence from occupying recall slots.Top-Kselection:Change type
Affected areas
Verification
GOCACHE=/private/tmp/deeix-559-full-cache go test ./...GOCACHE=/private/tmp/deeix-559-final-vet-cache go vet ./...-shuffle=on -count=5go test -racepnpm api:checkgit diff --checkDEEIX_TEST_DATABASE_DSN; it was skipped locally because no valid test DSN was configured.Screenshots, API examples, or logs
No frontend or public API changes.
The regression is covered by tests for:
LIMITand vectorTop-K.Configuration, migration, and compatibility notes
Documentation
Security and privacy
Historical evidence queries now enforce conversation, user, message-branch, and run ownership together. Invalid, ambiguous, cross-user, or cross-branch evidence fails closed and is not injected into model context.
Checklist
.pycfiles,.envfiles, and local storage data are not committed.