Map test with UMD build#395
Draft
alexluckett wants to merge 3 commits into
Draft
Conversation
Imports the accessibility test site from defra-design/map-test under demo/, pointing @defra/interactive-map at the local repo (file:../..) and flattening the old plugins/beta and providers/beta plugin-asset paths to match the monorepo structure. All 11 pages verified in headless Chromium against the local UMD builds: defra.* globals resolve and the map boots to a live canvas on every page.
Replaces the file:../.. prototype-kit plugin wiring with the exact consumer setup: scripts/install-local-packages.sh packs core plus the 7 provider/plugin packages the demo uses, npm-installs the tarballs (npm resolves maplibre-gl via the new required peer deps), and copies each package's dist into app/assets/vendor. Views now load the UMD bundles with standard <script src> tags instead of /plugin-assets/. All 11 pages re-verified in headless Chromium: defra.* globals resolve and the map boots to a live canvas.
|
Gives every UMD-shipping workspace package a govuk-prototype-kit.config.json (exposing /dist/umd and /dist/css where present) so prototype kit apps that install the split packages get their bundles served natively under /plugin-assets/<package>/dist/... — matching the install-only-what-you-use model. esri and draw-es are skipped (ESM-only, no UMD build). map-test now loads each package via its own plugin-assets path, dropping the vendor-copy step. All 11 pages re-verified in headless Chromium.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.