Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IM-401 - move plugins out of /beta #402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
IM-401 - move plugins out of /beta #402
Changes from all commits
15ac98d6cd4409File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
Check warning on line 9 in plugins/datasets/src/adapters/esri/esriLayerAdapter.js
Remove the unused function parameter "patternRegistry" or rename it to "_patternRegistry" to make intention explicit.
Check warning on line 9 in plugins/datasets/src/adapters/esri/esriLayerAdapter.js
Remove the unused function parameter "symbolRegistry" or rename it to "_symbolRegistry" to make intention explicit.
Check warning on line 13 in plugins/datasets/src/adapters/esri/esriLayerAdapter.js
Complete the task associated to this "TODO" comment.
Check failure on line 36 in plugins/datasets/src/adapters/esri/esriLayerAdapter.js
Unexpected `for await...of` of a value that is not async iterable.
Check warning on line 114 in plugins/datasets/src/adapters/esri/esriLayerAdapter.js
Prefer using an optional chain expression instead, as it's more concise and easier to read.
Check failure on line 130 in plugins/datasets/src/adapters/esri/esriLayerAdapter.js
Add the missing "else" clause.
Check warning on line 192 in plugins/datasets/src/adapters/esri/esriLayerAdapter.js
Complete the task associated to this "TODO" comment.
Check warning on line 198 in plugins/datasets/src/adapters/esri/esriLayerAdapter.js
Complete the task associated to this "TODO" comment.
Check warning on line 4 in plugins/datasets/src/api/getStyle.js
Remove the unused function parameter "pluginState" or rename it to "_pluginState" to make intention explicit.
Check warning on line 5 in plugins/datasets/src/api/setData.js
Remove the unused function parameter "pluginState" or rename it to "_pluginState" to make intention explicit.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.