Refactor output export logic in dementpy.py#49
Merged
Conversation
Commented out the Export_format variable and simplified output export logic.
Comment out the export_to_netcdf method and related imports.
Comment out the export_to_netcdf method and related code for exporting data to NetCDF format.
Commented out the import statement for xarray.
Deleted the output format selection parameter and added dispersal, which is in runtime.txt in the other input folders (grassland and scrubland).
jgwalkup
marked this pull request as ready for review
July 15, 2026 20:51
Collaborator
Author
|
@eusimeo I was able to download and run this code locally, without bugs. Let me know if you have any issues with it. |
eusimeo
approved these changes
Jul 16, 2026
eusimeo
left a comment
eusimeo
left a comment
Contributor
There was a problem hiding this comment.
Seen changes and agree to keep them as it is now
Contributor
|
#49 is addressed in this merge. Will download and check the code runs properly after merge. E.S. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commented out the Export_format variable and simplified output export logic. The export as NetCDF version has many too many bugs, so this version will only allow for exporting model outputs in CSV format for simplicity and ease of use.