orders: add position management commands and overlay - #5891
Open
Robuske wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds direct manager-order position management to
orders:orders positions [--show-id]lists fort-wide manager orders in displayed priority order.orders move <current-position> <new-position> [--show-id]moves the existing order pointer withinworld.manager_orders.all.orders.positionadds inline position fields to the Work Orders screen and uses the same move logic as the command.The native
ordersplugin dispatches the new subcommands to Lua. Expected validation failures are returned normally, avoiding the extraFailed Lua callmessage.Testing
Built the
ordersplugin with the DFHack Visual Studio build.Ran:
Result: 18/18 tests passed, 227/227 checks passed.
Performed in-game testing of command moves, validation errors, inline editing, cancellation, focus handling, scrolling, and search-overlay interaction.
Documentation
Includes
orderscommand andorders.positionoverlay documentation, plus the requireddocs/changelog.txtentry.