fix(net-filter): load policy files and clarify debug usage - #143
Merged
xu-lang merged 1 commit intoSep 14, 2026
Merged
Conversation
|
/review |
PR Reviewer Guide 🔍(Review updated until commit 95200cb)Here are some key observations to aid the review process:
|
yuKing123-king
force-pushed
the
fix/net-filter-policy-and-debug
branch
from
September 14, 2026 02:56
5f8041e to
562ca03
Compare
Signed-off-by: Wang Yu <wangyu6@uniontech.com>
yuKing123-king
force-pushed
the
fix/net-filter-policy-and-debug
branch
from
September 14, 2026 02:58
562ca03 to
95200cb
Compare
|
Persistent review updated to latest commit 95200cb |
1 similar comment
|
Persistent review updated to latest commit 95200cb |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
解决的问题
net-filter之前没有真正读取-p指定的 policy 文件,导致配置文件路径参数不生效。--debug的帮助说明不够明确,容易让人误以为可以写成-d 9或--debug 9。修改内容
filter/net-filter.cpp中恢复nf.load_rules(poli_path.c_str()),让-p指定的 policy 文件真正生效。main()里那条硬编码的默认 TCPlog规则,避免覆盖或污染 policy 配置结果。--help中debug参数的说明,明确写出推荐用法-d9/--debug=9。docs/net-filter.md中同步更新了 debug 参数说明。