Skip to content

Improvement: Add mesh handle build to t8code test workflow #2399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lenaploetzke wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Improvement: Add mesh handle build to t8code test workflow #2399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
786f212
Add mesh handle config to correct workflows
lenaploetzke Aug 19, 2026
480e1f2
Remove assertion for ghosts
lenaploetzke Aug 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .github/workflows/test_t8code.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,14 @@ jobs:
run: export TEST_LEVEL_FLAG="-DT8CODE_TEST_LEVEL=${{ inputs.TEST_LEVEL }}"
&& echo TEST_LEVEL_FLAG="$TEST_LEVEL_FLAG" >> $GITHUB_ENV
- name: build config variables
run: export CONFIG_OPTIONS="${TEST_LEVEL_FLAG} -GNinja -DCMAKE_C_FLAGS_DEBUG=${DEBUG_CONFIG} -DCMAKE_CXX_FLAGS_DEBUG=${DEBUG_CONFIG} -DT8CODE_USE_SYSTEM_SC=ON -DT8CODE_USE_SYSTEM_P4EST=ON -DT8CODE_BUILD_PEDANTIC=ON -DT8CODE_BUILD_WALL=ON -DT8CODE_BUILD_WERROR=ON -DT8CODE_BUILD_WEXTRA=ON -DT8CODE_ENABLE_MPI=$MPI -DCMAKE_BUILD_TYPE=$BUILD_TYPE -DSC_DIR=$SC_PATH/install/cmake -DP4EST_DIR=$P4EST_PATH/install/cmake"
&& echo CONFIG_OPTIONS="$CONFIG_OPTIONS" >> $GITHUB_ENV
run: |
export CONFIG_OPTIONS="${TEST_LEVEL_FLAG} -GNinja -DCMAKE_C_FLAGS_DEBUG=${DEBUG_CONFIG} \
-DCMAKE_CXX_FLAGS_DEBUG=${DEBUG_CONFIG} -DT8CODE_USE_SYSTEM_SC=ON -DT8CODE_USE_SYSTEM_P4EST=ON \
-DT8CODE_BUILD_PEDANTIC=ON -DT8CODE_BUILD_WALL=ON -DT8CODE_BUILD_WERROR=ON \
-DT8CODE_BUILD_WEXTRA=ON -DT8CODE_ENABLE_MPI=$MPI -DCMAKE_BUILD_TYPE=$BUILD_TYPE \
-DT8CODE_BUILD_MESH_HANDLE=ON -DSC_DIR=$SC_PATH/install/cmake \
-DP4EST_DIR=$P4EST_PATH/install/cmake"
echo CONFIG_OPTIONS="$CONFIG_OPTIONS" >> $GITHUB_ENV
# cmake and test
- name: Printing MPI compiler info
run: mpicc --version && mpirun --version
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test_t8code_api.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ jobs:
run: export TEST_LEVEL_FLAG="-DT8CODE_TEST_LEVEL=${{ inputs.TEST_LEVEL }}"
&& echo TEST_LEVEL_FLAG="$TEST_LEVEL_FLAG" >> $GITHUB_ENV
- name: build config variables
run: export CONFIG_OPTIONS="${TEST_LEVEL_FLAG} -GNinja -DCMAKE_C_FLAGS_DEBUG=${DEBUG_CONFIG} -DCMAKE_CXX_FLAGS_DEBUG=${DEBUG_CONFIG} -DT8CODE_BUILD_FORTRAN_INTERFACE=ON -DT8CODE_BUILD_MESH_HANDLE=ON -DT8CODE_USE_SYSTEM_SC=ON -DT8CODE_USE_SYSTEM_P4EST=ON -DT8CODE_BUILD_PEDANTIC=ON -DT8CODE_BUILD_WALL=ON -DT8CODE_BUILD_WERROR=ON -DT8CODE_BUILD_WEXTRA=ON -DT8CODE_ENABLE_MPI=$MPI -DCMAKE_BUILD_TYPE=$BUILD_TYPE -DSC_DIR=$SC_PATH/install/cmake -DP4EST_DIR=$P4EST_PATH/install/cmake"
run: export CONFIG_OPTIONS="${TEST_LEVEL_FLAG} -GNinja -DCMAKE_C_FLAGS_DEBUG=${DEBUG_CONFIG} -DCMAKE_CXX_FLAGS_DEBUG=${DEBUG_CONFIG} -DT8CODE_BUILD_FORTRAN_INTERFACE=ON -DT8CODE_USE_SYSTEM_SC=ON -DT8CODE_USE_SYSTEM_P4EST=ON -DT8CODE_BUILD_PEDANTIC=ON -DT8CODE_BUILD_WALL=ON -DT8CODE_BUILD_WERROR=ON -DT8CODE_BUILD_WEXTRA=ON -DT8CODE_ENABLE_MPI=$MPI -DCMAKE_BUILD_TYPE=$BUILD_TYPE -DSC_DIR=$SC_PATH/install/cmake -DP4EST_DIR=$P4EST_PATH/install/cmake"
&& echo CONFIG_OPTIONS="$CONFIG_OPTIONS" >> $GITHUB_ENV
# cmake and test with api options
- name: echo cmake line
Expand Down
8 changes: 6 additions & 2 deletions .github/workflows/test_t8code_w_shipped_submodules.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,12 @@ jobs:
run: export TEST_LEVEL_FLAG="-DT8CODE_TEST_LEVEL=${{ inputs.TEST_LEVEL }}"
&& echo TEST_LEVEL_FLAG="$TEST_LEVEL_FLAG" >> $GITHUB_ENV
- name: build config variables
run: export CONFIG_OPTIONS="${TEST_LEVEL_FLAG} -GNinja -DCMAKE_C_FLAGS_DEBUG=${DEBUG_CONFIG} -DCMAKE_CXX_FLAGS_DEBUG=${DEBUG_CONFIG} -DT8CODE_BUILD_PEDANTIC=ON -DT8CODE_BUILD_WALL=ON -DT8CODE_BUILD_WERROR=ON -DT8CODE_BUILD_WEXTRA=ON -DT8CODE_ENABLE_MPI=$MPI -DCMAKE_BUILD_TYPE=$BUILD_TYPE"
&& echo CONFIG_OPTIONS="$CONFIG_OPTIONS" >> $GITHUB_ENV
run: |
export CONFIG_OPTIONS="${TEST_LEVEL_FLAG} -GNinja -DCMAKE_C_FLAGS_DEBUG=${DEBUG_CONFIG} \
-DCMAKE_CXX_FLAGS_DEBUG=${DEBUG_CONFIG} -DT8CODE_BUILD_MESH_HANDLE=ON -DT8CODE_BUILD_PEDANTIC=ON \
-DT8CODE_BUILD_WALL=ON -DT8CODE_BUILD_WERROR=ON -DT8CODE_BUILD_WEXTRA=ON -DT8CODE_ENABLE_MPI=$MPI \
-DCMAKE_BUILD_TYPE=$BUILD_TYPE"
echo CONFIG_OPTIONS="$CONFIG_OPTIONS" >> $GITHUB_ENV
# cmake and test
- name: Printing MPI compiler info
run: mpicc --version && mpirun --version
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/testsuite.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ jobs:
BUILD_TYPE: ${{ matrix.BUILD_TYPE }}
TEST_LEVEL: ${{ github.event_name == 'pull_request' && 'T8_TEST_LEVEL_MEDIUM' || 'T8_TEST_LEVEL_FULL' }} # Set TEST_LEVEL to medium if the event is a PR, otherwise full.

# Run t8code linkage tests with and without MPI and in serial and debug mode
# Run t8code api tests only with MPI and in serial and debug mode
t8code_api_tests:
needs: preparation
uses: ./.github/workflows/test_t8code_api.yml
Expand Down
6 changes: 3 additions & 3 deletions test/mesh_handle/competences/t8_gtest_dg_competences.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,9 @@ TEST (t8_gtest_dg_competences, remote_ranks)

const t8_locidx_t num_local = mesh->get_num_local_elements ();
const t8_locidx_t num_ghosts = mesh->get_num_ghosts ();
if ((mesh->get_dimension () > 1) && (num_local > 1)) {
// Ensure that we actually test with ghost elements.
ASSERT_GT (num_ghosts, 0);
// Test does not make sense without ghosts.
if (!(num_ghosts > 0)) {
GTEST_SKIP () << "Skipping test as no ghost elements are created.";
}

int mpirank;
Expand Down
5 changes: 0 additions & 5 deletions test/mesh_handle/competences/t8_gtest_handle_data.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,11 +52,6 @@ TEST (t8_gtest_handle_data, set_and_get_element_data)
auto mesh
= t8_mesh_handle::handle_hypercube_hybrid_uniform_default<mesh_class> (level, sc_MPI_COMM_WORLD, true, false);

if ((mesh->get_dimension () > 1) && (mesh->get_num_local_elements () > 1)) {
// Ensure that we actually test with ghost elements.
EXPECT_GT (mesh->get_num_ghosts (), 0);
}

// Create element data for all local mesh elements.
std::vector<data_per_element> element_data;
for (const auto &elem : *mesh) {
Expand Down
12 changes: 2 additions & 10 deletions test/mesh_handle/t8_gtest_ghost.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,12 +67,8 @@ TEST_P (t8_mesh_ghost_test, check_ghosts)
mesh->set_ghost ();
mesh->commit ();
EXPECT_EQ (mesh->get_num_ghosts (), t8_forest_get_num_ghosts (mesh->get_forest ()));
if ((mesh->get_dimension () > 1) && (mesh->get_num_local_elements () > 1)) {
// Ensure that we actually have ghost elements in this test.
EXPECT_GT (mesh->get_num_ghosts (), 0);
}
else {
GTEST_SKIP () << "Skipping test as no ghost elements are created for 1D or single element meshes.";
if (!(mesh->get_num_ghosts () > 0)) {
GTEST_SKIP () << "Skipping test as no ghost elements are created.";
}

// Check functions for ghost elements.
Expand Down Expand Up @@ -121,10 +117,6 @@ TEST_P (t8_mesh_ghost_test, compare_neighbors_to_forest)

const t8_mesh_handle::mesh<> mesh (forest);
EXPECT_EQ (mesh.get_num_ghosts (), t8_forest_get_num_ghosts (forest));
if ((mesh.get_dimension () > 1) && (mesh.get_num_local_elements () > 1)) {
// Ensure that we have ghost elements in this test.
EXPECT_GT (mesh.get_num_ghosts (), 0);
}

// Iterate over the elements of the forest and of the mesh handle simultaneously and compare results.
auto mesh_iterator = mesh.cbegin ();
Expand Down
Loading