Feat: TPwriter's enable/disable logic now determined by readout apps#290
Draft
henry-wallace-phys wants to merge 8 commits into
Draft
Feat: TPwriter's enable/disable logic now determined by readout apps#290henry-wallace-phys wants to merge 8 commits into
henry-wallace-phys wants to merge 8 commits into
Conversation
gcrone
reviewed
Jun 15, 2026
|
|
||
| for(auto& rule : get_network_rules()){ | ||
| /// HACK (minor): We assume TPs will always contain this exact rule | ||
| if(rule->UID()!="tpset-net-rule"){continue;} |
Contributor
There was a problem hiding this comment.
Why not use the same logic as at line 50 where you will at least be consistent
Author
There was a problem hiding this comment.
Ah because I was being silly! Will fix in a moment
gcrone
reviewed
Jun 15, 2026
| for(auto parent : configuration().referenced_by(*rule)){ | ||
|
|
||
| // Safer than blindly casting to ReadoutApplication (RA) | ||
| if(!parent->castable("ReadoutApplication")) continue; |
Contributor
There was a problem hiding this comment.
I think casting and checking for nullptr is just as safe. The continue should really be on a line of its own, surrounded by braces. If statements without braces are against the coding conventions and really screw up my reading of code.
mroda88
requested changes
Jun 16, 2026
mroda88
left a comment
mroda88
left a comment
Contributor
There was a problem hiding this comment.
Nope, the function to extend is compute_disabled_state. To make sure, it is the right one, add the the qualifier override.
added 6 commits
June 16, 2026 11:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously TPStreamWriterApplication required additional external logic to determine its enable disable state.
If there are no readout apps + none of tp generation enabled then the TPStreamWriter is itself disabled.
This is now moved internally using the 'tpset-net-rule' to find all connected readout applications. We find all configuration objects that use this rule, loop over them + find all ReadoutApplications used by them.
Type of change
Testing checklist
dbt-build --unittest)pytest -s minimal_system_quick_test.py)dunedaq_integtest_bundle.sh)python -m pytest)pre-commit run --all-files)Comments here on the testing
Further checks
dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)(Indicate issue here: # (issue))