Skip to content

Include TAMakerProtoDUNEBSMWindowAlgorithm in appmodel triggers.schema.xml #291

Open
CiaranH1997 wants to merge 7 commits into
developfrom
feature/bsm_window_appmodel
Open

Include TAMakerProtoDUNEBSMWindowAlgorithm in appmodel triggers.schema.xml #291
CiaranH1997 wants to merge 7 commits into
developfrom
feature/bsm_window_appmodel

Conversation

@CiaranH1997

Copy link
Copy Markdown

Description

If full description and testing details are included on a parent issue, please link to that here.
See issue # for details

Otherwise, please include a summary of the change and which issue is fixed (if any).
Include relevant motivation and context, including a target environment and dunedaq version if known.
Also list any dependencies that are required for this change.

Addresses issue #

Add TAMakerProtoDUNEBSMWindowAlgorithm as a new class in triggers.schema.xml to allow ProtoDUNEBSMWindow trigger algorithm to be run in DUNE DAQ. Nothing else is changed, just an additional class that defines the user-changeable parameters of TAMakerProtoDUNEBSMWindowAlgorithm.

Please also include instructions for how a reviewer can test your changes.

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature or enhancement (non-breaking change which adds functionality)
  • Optimization (non-breaking change that improves code/performance)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Testing checklist

  • Unit tests pass (e.g. dbt-build --unittest)
  • Minimal system quicktest passes (pytest -s minimal_system_quick_test.py)
  • Full set of integration tests pass (dunedaq_integtest_bundle.sh)
  • Python tests pass if applicable (e.g. python -m pytest)
  • Pre-commit hooks run successfully if applicable (e.g. pre-commit run --all-files)

Comments here on the testing

Further checks

  • Code is commented where needed, particularly in hard-to-understand areas
  • Code style is correct (dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)
  • If applicable, new tests have been added or an issue has been opened to tackle that in the future.
    (Indicate issue here: # (issue))

@CiaranH1997 CiaranH1997 self-assigned this Jun 21, 2026

@MRiganSUSX MRiganSUSX left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CiaranH1997,
Few changes are suggested.

Comment thread schema/appmodel/trigger.schema.xml Outdated
Comment thread schema/appmodel/trigger.schema.xml Outdated
Comment thread schema/appmodel/trigger.schema.xml Outdated
Comment thread schema/appmodel/trigger.schema.xml Outdated
@CiaranH1997 CiaranH1997 requested a review from MRiganSUSX June 25, 2026 09:29
…nd 1. User trying to set a threshold outside these limits now throws an error, as it should.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants