Skip to content

before_first_request is deprecated, use app_context() instead#36

Merged
eflumerf merged 1 commit into
developfrom
eflumerf/FixStartup
Jun 11, 2026
Merged

before_first_request is deprecated, use app_context() instead#36
eflumerf merged 1 commit into
developfrom
eflumerf/FixStartup

Conversation

@eflumerf

@eflumerf eflumerf commented Jun 11, 2026

Copy link
Copy Markdown
Member

Description

before_first_request is deprecated in Flask 2.2+. Advice in https://stackoverflow.com/questions/73570041/flask-deprecated-before-first-request-how-to-update is to use with app.app_context(): instead.

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature or enhancement (non-breaking change which adds functionality)
  • Optimization (non-breaking change that improves code/performance)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Testing checklist

  • Unit tests pass (e.g. dbt-build --unittest)
  • Minimal system quicktest passes (pytest -s minimal_system_quick_test.py)
  • Full set of integration tests pass (dunedaq_integtest_bundle.sh)
  • Python tests pass if applicable (e.g. python -m pytest)
  • Pre-commit hooks run successfully if applicable (e.g. pre-commit run --all-files)

Comments here on the testing

Further checks

  • Code is commented where needed, particularly in hard-to-understand areas
  • Code style is correct (dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)
  • If applicable, new tests have been added or an issue has been opened to tackle that in the future.
    (Indicate issue here: # (issue))

@eflumerf eflumerf requested review from bieryAtFnal and jcpunk June 11, 2026 14:47

@bieryAtFnal bieryAtFnal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. with these changes, I see regression tests run successfully.

@eflumerf eflumerf merged commit 940ca89 into develop Jun 11, 2026
1 check passed
@eflumerf eflumerf deleted the eflumerf/FixStartup branch June 11, 2026 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants