Fixed parts of hdf5write_test_hwmap.data.xml…

[bieryAtFnal]

…based on the results of running 'oks_check_schema -f hdf5write_test.data.xml'

Description

Recently, Marco pointed out that parts of the hdf5write_test_hwmap.data.xml configuration file have become out-of-date. Running oks_check_schema -f hdf5write_test.data.xml showed several problems. The changes in this PR fix those problems.

One question that I have is whether it is appropriate to have quotes around integer values in OKS configuration files such as this. For example, in the AVXThresholdProcessor values on lines 94-96. Is that OK?

Here are suggested instructions for testing these changes:

DATE_PREFIX=`date '+%d%b'`
TIME_SUFFIX=`date '+%H%M'`

source /cvmfs/dunedaq.opensciencegrid.org/setup_dunedaq.sh
setup_dbt latest
dbt-create -n NFD_DEV_260705_A9 ${DATE_PREFIX}FDDevConfigFixes_${TIME_SUFFIX}
cd ${DATE_PREFIX}FDDevConfigFixes_${TIME_SUFFIX}/sourcecode

git clone https://github.com/DUNE-DAQ/daqsystemtest.git -b kbiery/test_config_fixes
git clone https://github.com/DUNE-DAQ/dfmodules.git -b kbiery/test_config_fixes
cd ..

. ./env.sh
dbt-build -j 12
dbt-workarea-env

oks_check_schema -f sourcecode/dfmodules/test/config/hdf5write_test.data.xml

echo ""
echo -e "\U1F535 \U2705 Note that the schema check didn't report any problems when run on the modified dfmodules code. \U2705 \U1F535"
echo ""
echo ""

Type of change

• Bug fix (non-breaking change which fixes an issue)

Testing checklist

• Unit tests pass (e.g. dbt-build --unittest)
• Minimal system quicktest passes (pytest -s minimal_system_quick_test.py)

[eflumerf]

I'm guessing there is/will be a corresponding PR in daqsystemtest?

[mroda88]

Tested with today's nightly. Indeed, no errors are reported in any of the configuration data files of this branch.

[bieryAtFnal]

Yes, there is now a corresponding PR in daqsystemtest, DUNE-DAQ/daqsystemtest#327.

Thanks for the review; merging now.