K8s: Hacky changes for TPC#966
Conversation
|
The k8s configurations for |
| boot_request.process_description.metadata.tree_id, podname, boot_request | ||
| ) | ||
|
|
||
| # Format the hostname for safety |
There was a problem hiding this comment.
As this PR is a complete hack, I would suggest leaving the long-term correct implementation in the code, but commented out with a relevant specifier as to why it was commented out. This should also have a child issue written that informs about the importance of reverting this change.
| pwd: str, | ||
| ) -> BootRequest: | ||
| host = format_hostname(app["restriction"]) | ||
| host = app["restriction"] |
PawelPlesniak
left a comment
There was a problem hiding this comment.
Thank you Claudia.
For this process manager, did you run a full TPC readout or what is just in emulation mode? This was unclear to me from the description of this PR.
Hi Pawel, thanks, I have only tested it in emulation mode, I plan to test it with the actual BDE readout this week (as the TDE is still not available). |
|
To validate the use of the emulation mode, I ran the following steps Which got me the expected for multiple minutes, ultimately leading to gRPC timeouts as This was taken 3 times to ensure reproducibility. When doing this, I was running as myself starting from For documentation, I was able to see the pod manifests by viewing the namespace I also find the naming path of |
Description
Fixes issue #872
This PR enables a hacky way to readout the full TPC on
np02-srv-005, addresses step2 in #895Changes:
Change k8s configurations to specify resources for both TDE and BDE apps.
For BDE apps, strip '-1' from the hostname in the OKS config to schedule them on the actual
np02-srv-005, but keep them for resource allocation from the k8s PM config.To test it on the emulation mode, uses ehn1-daqconfigs
Example output:
Type of change
List of required branches from other repositories
N/A
Change log
see above
Suggested manual testing checklist
LIST COMMANDS TO DEMONSTRATE CHANGE
Developer checklist
Prior to marking this as "Ready for Review"
Tests ran on: np04-srv-019 from release NFD_DEV_260629_A9
Unit tests - some tests can't be ran on the CI. This is documented. If this PR checks a feature that can't be tested with CI, this has been marked appropriately.
Integration tests - the
daqsystemtest_integtest_bundlerequires a lot of resources, and connections to the EHN1 infrastructure. Check the cross referenced list if you can't run these. The developer needs to run at least the .pytest --marker) passeddaqsystemtest_integtest_bundle.sh -k minimal_system_quick_test.pydaqsystemtest_integtest_bundle.sh./scripts/drunc_integtest_bundle.sh)Final checklist prior to marking this as "Ready for Review"
Reviewer checklist
src/daqsystemtest_integtest_bundle.sh -k minimal_system_quick_test.pyifdaqsystemtest_integtest_bundle.shdruncare in the log filesdruncfailure appears:scripts/drunc_integtest_bundle.sh)Once the above boxes are checked, the PR(s) can be merged following the steps below.
Choose one of the following an complete all substepsPrior to merging
Once completed, the reviewer can merge the PR.
Notification message for a Slack channel
Note - this should be to #dunedaq-integration for general workflow that isn't during a release candidate period, and to #daq-release-prep otherwise.
For an single merge that changes the user workflow
For co-ordinated merge