Added support in integrationtest_drunc.py for finding a predefined configuration file...#159
Merged
Merged
Conversation
added 2 commits
June 10, 2026 15:37
…nfiguration files in one of the paths listed in the DUNEDAQ_DB_PATH env var.
…ontest_drunc.py to strip off any leading slash when checking for the preseence of the files in the DB path
andrewmogan
approved these changes
Jun 11, 2026
andrewmogan
left a comment
Contributor
There was a problem hiding this comment.
Works as advertised. In addition to the listed test, I confirmed that minimal_system_quick_test works after switching to this branch. The code changes make sense and maintain backwards compatibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... in one of the paths listed in the DUNEDAQ_DB_PATH env var.
Description
While helping Pawel debug an issue with a new
druncintegration test, I noticed that the cross-check that the integrationtest infrastructure does to verify that a file with a pre-defined DUNE-DAQ configuration exists was not taking into account the DUNEDAQ_DB_PATH. This seemed overly restrictive, so I added this functionality.With this change, we don't need to specify pre-defined config files in our integetests with code like the following:
and instead can use simpler assignments like the following:
Here are suggested steps for testing this change. They locally modify an existing integtest to use the simpler pre-defined config file assignment and show that the test fails without the code change in this PR, and succeeds when the code in this PR is used.
Type of change
Testing checklist
pytest -s minimal_system_quick_test.py)dunedaq_integtest_bundle.sh)Further checks