Skip to content

Added support for specifying drunc command-line arguments inside integtests#160

Open
bieryAtFnal wants to merge 1 commit into
developfrom
kbiery/dunerc_cmd_args
Open

Added support for specifying drunc command-line arguments inside integtests#160
bieryAtFnal wants to merge 1 commit into
developfrom
kbiery/dunerc_cmd_args

Conversation

@bieryAtFnal

Copy link
Copy Markdown
Contributor

Description

Pawel requested the ability to specify drunc command-line arguments inside integtests. The changes in this PR provide that ability.

The changes include the addition of a dunerc_cmd_args field to the integtest_param_base_class in data_classes.py and the addition of the contents of that field in the startup of drunc in integrationtest_drunc.py.

To test this, one can simply include these changes in a software area based on a recent nightly build, pip install this package, specify one or more drunc command-line arguments in the dunerc_cmd_args parameter in an integtest, and run the integtest.

Here is a sample addition to an integtest:

--- a/integtest/minimal_system_quick_test.py
+++ b/integtest/minimal_system_quick_test.py
@@ -77,6 +77,7 @@ conf_dict.dro_map_config.n_streams = number_of_data_producers
 conf_dict.op_env = "integtest"
 conf_dict.config_session_name = "minimal"
 conf_dict.tpg_enabled = False
+conf_dict.dunerc_cmd_args = ["--no-override-logs"]

 # For testing, allow drunc to manage ConnectivityService
 #conf_dict.connsvc_control = ConnSvcControl.RUNCONTROL

Type of change

  • New feature or enhancement (non-breaking change which adds functionality)

Testing checklist

  • Minimal system quicktest passes (pytest -s minimal_system_quick_test.py)

…ta_classes.py to support developer-specified command-line arguments for run control in integtests.

@PawelPlesniak PawelPlesniak left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Kurt, this worked exactly as intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants