Skip to content

LB write returns iterator to the element #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
denizergonul wants to merge 2 commits into
base: develop
Choose a base branch
from
+28 −6
Open

LB write returns iterator to the element #35

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
906dfac
DataHandlingModel write update
denizergonul Jul 3, 2026
9aef5c6
Removed old write
denizergonul Jul 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 28 additions & 6 deletions include/snbmodules/readout/detail/SNBDataHandlingModel.hxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,16 @@ SNBDataHandlingModel<RDT, RHT, LBT, RPT, IDT>::init(const appmodel::DataHandlerM
m_post_processing_delay_min_wait = mcfg->get_module_configuration()->get_post_processing_delay_min_wait();
m_post_processing_delay_max_wait = mcfg->get_module_configuration()->get_post_processing_delay_max_wait();

if (m_processing_delay_ticks) {
if constexpr (datahandlinglibs::ExpectsOrder<LBT>) {
ers::error(datahandlinglibs::ConfigurationError(
ERS_HERE,
m_sourceid,
"Queue buffers (FixedRateQueue, BinarySearchQueue) expect in-order data and must use "
"post_processing_delay_ticks = 0."));
}
}

// Configure implementations:
m_raw_processor_impl->conf(mcfg);
// Configure the latency buffer before the request handler so the request handler can check for alignment
Expand Down Expand Up @@ -226,15 +236,27 @@ SNBDataHandlingModel<RDT, RHT, LBT, RPT, IDT>::process_item(RDT&& payload)
while (m_latency_buffer_impl->isFull()) {
std::this_thread::sleep_for(std::chrono::milliseconds(1));
}
if (!m_latency_buffer_impl->write(std::move(payload))) {
// TLOG_DEBUG(TLVL_TAKE_NOTE) << "***ERROR: Latency buffer insert failed! (Payload timestamp=" <<
// payload.get_timestamp() << ")";
m_num_lb_insert_failures++;
return;

const RDT* written = nullptr;
if constexpr (datahandlinglibs::ExpectsOrder<LBT>) {
if (!m_latency_buffer_impl->write(std::move(payload))) {
// TLOG_DEBUG(TLVL_TAKE_NOTE) << "***ERROR: Latency buffer insert failed! (Payload timestamp=" << payload.get_timestamp() << ")";
m_num_lb_insert_failures++;
return;
}
written = m_latency_buffer_impl->back();
} else {
const auto [returned, result] = m_latency_buffer_impl->write_and_return(std::move(payload));
if (!result) {
// TLOG_DEBUG(TLVL_TAKE_NOTE) << "***ERROR: Latency buffer insert failed! (Payload timestamp=" << payload.get_timestamp() << ")";
m_num_lb_insert_failures++;
return;
}
written = returned;
}

if (m_processing_delay_ticks == 0) {
m_raw_processor_impl->postprocess_item(m_latency_buffer_impl->back());
m_raw_processor_impl->postprocess_item(written);
++m_num_payloads;
++m_sum_payloads;
++m_stats_packet_count;
Expand Down
Loading