Fix primary runtime inspection without confirmation prompts - #28
Open
tatsuhitofuruta wants to merge 2 commits into
Open
tatsuhitofuruta wants to merge 2 commits into
tatsuhitofuruta wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--primarymode that inspects the exact current rollout throughCODEX_THREAD_ID.turn_context, require and emit its lowercase-UUIDturn_id, and use that identified turn's model and effort as the applied runtime evidence.gpt-5.6-sol/highevidence while preserving the existing auxiliary inspector contract and fail-closed behavior.Why
Sol Advisor 0.6.0 falls back to asking the user for Sol / High confirmation when host metadata is not exposed, even though Codex records the applied model and effort in each thread rollout. The existing auxiliary runtime inspector rejects primary sessions because they do not contain auxiliary-only
agent_rolemetadata.A live reproduction also showed an important turn boundary: selecting High in the UI while a Medium turn is already running does not retroactively change that turn. The rollout continues to report Medium until the next turn starts. Returning the validated latest
turn_idmakes the inspected model and effort attributable to one applied turn instead of to the task in general.This PR isolates the root-session runtime inspection fix for #25. The advisory hook and configuration UX proposed in #26 can be evaluated independently.
Verification
sh plugins/sol-advisor/scripts/verify.shgit diff --checkturn_idwitheffort: high.Fixes #25