Add --doubleTime argument - #5576
Merged
Merged
Conversation
Add a TIMELIMIT exit reason and report Slurm TIMEOUT with it. A worker that heeds Slurm's pre-timeout warning exits before the limit, so Slurm calls the job FAILED rather than TIMEOUT. Give such a worker a distinctive exit code that Slurm reads as TIMELIMIT, and ask for the warning as SIGUSR2 rather than SIGINT, so that a stray interrupt cannot be mistaken for it. Co-authored-by: Adam Novak <anovak@soe.ucsc.edu> Assisted-by: Claude Code:claude-opus-5[1m]
…the exit code and signal are defined
The expected output file has a trailing newline, so the comparison in check_out.sh failed without one. Co-authored-by: Adam Novak <anovak@soe.ucsc.edu> Assisted-by: Claude Code:claude-opus-5[1m]
Member
Author
|
I have some more relevant synthetic code pushed up to general-walltime-improvements in my Toil fork, for trying to sort out the chaining. |
This was referenced Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #5575.
While working on this, I figured out that chaining doesn't handle walltime correctly: it will chain to jobs for which there isn't enough walltime left.
I also was informed by somebody else's computer that, since the addition of walltime, the
AbstractGridEngineBatchSystems that didn't have it added won't work anymore, since it gets passed around inside them anyway.I'm not fixing any of that here, though. This should work for Slurm, and won't make chaining any worse.
Changelog Entry
To be copied to the draft changelog by merger:
--doubleTime=Trueflag for increasing thewalltimeof failing jobs.--defaultWalltimeinstead of--slurmTime.Reviewer Checklist
issues/XXXX-fix-the-thingin the Toil repo, or from an external repo.camelCasethat want to be insnake_case.docs/running/{cliOptions,cwl,wdl}.rstMerger Checklist