Skip to content

Add --doubleTime argument - #5576

Merged
adamnovak merged 5 commits into
masterfrom
issues/5575-double-time
Sep 1, 2026
Merged

Add --doubleTime argument#5576
adamnovak merged 5 commits into
masterfrom
issues/5575-double-time

Conversation

@adamnovak

@adamnovak adamnovak commented Aug 28, 2026

Copy link
Copy Markdown
Member

This should fix #5575.

While working on this, I figured out that chaining doesn't handle walltime correctly: it will chain to jobs for which there isn't enough walltime left.

I also was informed by somebody else's computer that, since the addition of walltime, the AbstractGridEngineBatchSystems that didn't have it added won't work anymore, since it gets passed around inside them anyway.

I'm not fixing any of that here, though. This should work for Slurm, and won't make chaining any worse.

Changelog Entry

To be copied to the draft changelog by merger:

  • Toil now supports --doubleTime=True flag for increasing the walltime of failing jobs.
  • Make Toil documentation suggest --defaultWalltime instead of --slurmTime.

Reviewer Checklist

  • Make sure it is coming from issues/XXXX-fix-the-thing in the Toil repo, or from an external repo.
    • If it is coming from an external repo, make sure to pull it in for CI with:
      contrib/admin/test-pr otheruser theirbranchname issues/XXXX-fix-the-thing
      
    • If there is no associated issue, create one.
  • Read through the code changes. Make sure that it doesn't have:
    • Addition of trailing whitespace.
    • New variable or member names in camelCase that want to be in snake_case.
    • New functions without type hints.
    • New functions or classes without informative docstrings.
    • Changes to semantics not reflected in the relevant docstrings.
    • New or changed command line options for Toil workflows that are not reflected in docs/running/{cliOptions,cwl,wdl}.rst
    • New features without tests.
  • Comment on the lines of code where problems exist with a review comment. You can shift-click the line numbers in the diff to select multiple lines.
  • Finish the review with an overall description of your opinion.

Merger Checklist

  • Make sure the PR passed tests, including the Gitlab tests, for the most recent commit in its branch.
  • Make sure the PR has been reviewed. If not, review it. If it has been reviewed and any requested changes seem to have been addressed, proceed.
  • Merge with the Github "Squash and merge" feature.
    • If there are multiple authors' commits, add Co-authored-by to give credit to all contributing authors.
  • Copy its recommended changelog entry to the Draft Changelog.
  • Append the issue number in parentheses to the changelog entry.

Automated Commit and others added 4 commits August 28, 2026 14:43
Add a TIMELIMIT exit reason and report Slurm TIMEOUT with it.

A worker that heeds Slurm's pre-timeout warning exits before the limit,
so Slurm calls the job FAILED rather than TIMEOUT. Give such a worker a
distinctive exit code that Slurm reads as TIMELIMIT, and ask for the
warning as SIGUSR2 rather than SIGINT, so that a stray interrupt cannot
be mistaken for it.

Co-authored-by: Adam Novak <anovak@soe.ucsc.edu>
Assisted-by: Claude Code:claude-opus-5[1m]
The expected output file has a trailing newline, so the comparison in
check_out.sh failed without one.

Co-authored-by: Adam Novak <anovak@soe.ucsc.edu>
Assisted-by: Claude Code:claude-opus-5[1m]
@adamnovak adamnovak changed the title Issues/5575 double time Add --doubleTime argument Aug 28, 2026
@adamnovak

Copy link
Copy Markdown
Member Author

I have some more relevant synthetic code pushed up to general-walltime-improvements in my Toil fork, for trying to sort out the chaining.

@adamnovak
adamnovak merged commit a9681fe into master Sep 1, 2026
3 checks passed
@adamnovak
adamnovak deleted the issues/5575-double-time branch September 1, 2026 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: --doubleTime

1 participant