SVLS-8857: dogstatsd/server: flush worker batchers on stop

[apiarian-datadog]

When dogstatsd_flush_incomplete_buckets is enabled, each worker flushes its batcher into the time sampler as it exits its run loop on stop. stop() closes stopChan and then waits on a workerWg so every worker's flush completes before the demultiplexer is torn down — guaranteeing the batched samples reach the sampler before its own final flush, with no dropped metrics on the shutdown of a short-lived process (serverless-init).

The flush is gated by the existing dogstatsd_flush_incomplete_buckets setting rather than a new key: that setting already flushes the sampler's final bucket, and draining the server batchers one layer upstream is the same "report everything we have on stop" intent. Long-running agents leave it off and are unaffected.

The legacy ServerlessFlush mechanism is left in place for now; it is removed once serverless-init stops using it.

Motivation

We're migrating to use as much of the existing metrics agent functionality in serverless-init as possible, but need some short-lived-agent features to make that work.

Describe how you validated your changes

Unit tests, as well as testing in a real serverelss-init short-lived test rig deployed to cloud run jobs.

[datadog-datadog-prod-us1-2]

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 51.09% (-0.00%)

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: c65f3be | Docs | Datadog PR Page | Give us feedback!}

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1c05b04774

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[dd-octo-sts]

Files inventory check summary

File checks results against ancestor b830dd64:

Results for datadog-agent_7.82.0~devel.git.410.c65f3be.pipeline.121362542-1_amd64.deb:

No change detected

[dd-octo-sts]

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor b830dd6
📊 Static Quality Gates Dashboard
🔗 SQG Job

Successful checks

Info

	Quality gate	Change	Size (prev → curr → max)
✅	agent_deb_amd64	+3.21 KiB (0.00% increase, -0.03% of buffer)	747.944 → 747.947 → 758.200
✅	agent_rpm_amd64	+3.21 KiB (0.00% increase, -0.03% of buffer)	747.928 → 747.931 → 758.170
✅	agent_suse_amd64	+3.21 KiB (0.00% increase, -0.03% of buffer)	747.928 → 747.931 → 758.170
✅	docker_agent_amd64	+3.21 KiB (0.00% increase, -0.04% of buffer)	806.766 → 806.769 → 813.790
✅	docker_agent_jmx_amd64	+3.2 KiB (0.00% increase, -0.05% of buffer)	997.663 → 997.666 → 1004.550
✅	docker_dogstatsd_amd64	+7.99 KiB (0.02% increase, -0.88% of buffer)	39.024 → 39.032 → 39.910
✅	dogstatsd_deb_amd64	+4.0 KiB (0.01% increase, -0.28% of buffer)	29.763 → 29.767 → 31.150
✅	dogstatsd_rpm_amd64	+4.0 KiB (0.01% increase, -0.28% of buffer)	29.763 → 29.767 → 31.150
✅	dogstatsd_suse_amd64	+4.0 KiB (0.01% increase, -0.28% of buffer)	29.763 → 29.767 → 31.150

24 successful checks with minimal change (< 2 KiB)

	Quality gate	Current Size
✅	agent_deb_amd64_fips	703.889 MiB
✅	agent_heroku_amd64	308.744 MiB
✅	agent_msi	617.204 MiB
✅	agent_rpm_amd64_fips	703.873 MiB
✅	agent_rpm_arm64	723.490 MiB
✅	agent_rpm_arm64_fips	683.043 MiB
✅	agent_suse_amd64_fips	703.873 MiB
✅	agent_suse_arm64	723.490 MiB
✅	agent_suse_arm64_fips	683.043 MiB
✅	docker_agent_arm64	807.345 MiB
✅	docker_agent_jmx_arm64	986.894 MiB
✅	docker_cluster_agent_amd64	208.159 MiB
✅	docker_cluster_agent_arm64	221.378 MiB
✅	docker_cws_instrumentation_amd64	7.447 MiB
✅	docker_cws_instrumentation_arm64	6.877 MiB
✅	docker_dogstatsd_arm64	37.180 MiB
✅	docker_host_profiler_amd64	305.035 MiB
✅	docker_host_profiler_arm64	316.120 MiB
✅	dogstatsd_deb_arm64	27.822 MiB
✅	iot_agent_deb_amd64	45.695 MiB
✅	iot_agent_deb_arm64	42.414 MiB
✅	iot_agent_deb_armhf	43.203 MiB
✅	iot_agent_rpm_amd64	45.696 MiB
✅	iot_agent_suse_amd64	45.695 MiB

[cit-pr-commenter-54b7da]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 4a4470bb-c37e-4b3b-a4b7-afdd000fe889

Baseline: 0b24b34
Comparison: c65f3be
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_logs	% cpu utilization	+2.29	[+1.20, +3.39]	1	Logs bounds checks dashboard
➖	quality_gate_idle	memory utilization	+0.21	[+0.15, +0.27]	1	Logs bounds checks dashboard
➖	quality_gate_idle_all_features	memory utilization	+0.13	[+0.09, +0.17]	1	Logs bounds checks dashboard
➖	quality_gate_security_no_fs_load	memory utilization	+0.06	[-0.04, +0.15]	1	Logs bounds checks dashboard
➖	quality_gate_security_idle	memory utilization	+0.02	[-0.04, +0.09]	1	Logs bounds checks dashboard
➖	quality_gate_metrics_logs	memory utilization	-0.20	[-0.45, +0.06]	1	Logs bounds checks dashboard
➖	quality_gate_security_mean_fs_load	memory utilization	-0.28	[-0.32, -0.24]	1	Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	observed_value	links
✅	quality_gate_idle	intake_connections	10/10	3 ≤ 4	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	147.67MiB ≤ 154MiB	bounds checks dashboard
✅	quality_gate_idle	total_bytes_received	10/10	580.21KiB ≤ 819.20KiB	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	3 ≤ 4	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	486.06MiB ≤ 495MiB	bounds checks dashboard
✅	quality_gate_idle_all_features	total_bytes_received	10/10	0.89MiB ≤ 1.25MiB	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	4 ≤ 6	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	179.97MiB ≤ 195MiB	bounds checks dashboard
✅	quality_gate_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_logs	total_bytes_received	10/10	264.21MiB ≤ 292MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	349.05 ≤ 2000	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	3 ≤ 6	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	392.08MiB ≤ 430MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_metrics_logs	total_bytes_received	10/10	0.86GiB ≤ 1.04GiB	bounds checks dashboard
✅	quality_gate_security_idle	cpu_usage	10/10	28.45 ≤ 40	bounds checks dashboard
✅	quality_gate_security_idle	memory_usage	10/10	296.91MiB ≤ 330MiB	bounds checks dashboard
✅	quality_gate_security_mean_fs_load	cpu_usage	10/10	63.13 ≤ 80	bounds checks dashboard
✅	quality_gate_security_mean_fs_load	memory_usage	10/10	271.92MiB ≤ 310MiB	bounds checks dashboard
✅	quality_gate_security_no_fs_load	cpu_usage	10/10	23.65 ≤ 40	bounds checks dashboard
✅	quality_gate_security_no_fs_load	memory_usage	10/10	286.05MiB ≤ 320MiB	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

Replicate Execution Details

We run multiple replicates for each experiment/variant. However, we allow replicates to be automatically retried if there are any failures, up to 8 times, at which point the replicate is marked dead and we are unable to run analysis for the entire experiment. We call each of these attempts at running replicates a replicate execution. This section lists all replicate executions that failed due to the target crashing or being oom killed.

Note: In the below tables we bucket failures by experiment, variant, and failure type. For each of these buckets we list out the replicate indexes that failed with an annotation signifying how many times said replicate failed with the given failure mode. In the below example the baseline variant of the experiment named experiment_with_failures had two replicates that failed by oom kills. Replicate 0, which failed 8 executions, and replicate 1 which failed 6 executions, all with the same failure mode.

Experiment	Variant	Replicates	Failure	Logs	Debug Dashboard
experiment_with_failures	baseline	0 (x8) 1 (x6)	Oom killed		Debug Dashboard

The debug dashboard links will take you to a debugging dashboard specifically designed to investigate replicate execution failures.

❌ Retried Profiling Replicate Execution Failures (ddprof)

Note: Profiling replicas may still be executing. See the debug dashboard for up to date status.

Experiment	Variant	Replicates	Failure	Debug Dashboard
quality_gate_idle_all_features	baseline	10	Oom killed	Debug Dashboard
quality_gate_idle_all_features	comparison	10	Oom killed	Debug Dashboard
quality_gate_logs	baseline	10	Oom killed	Debug Dashboard
quality_gate_logs	comparison	10	Oom killed	Debug Dashboard
quality_gate_metrics_logs	baseline	10	Oom killed	Debug Dashboard
quality_gate_metrics_logs	comparison	10	Oom killed	Debug Dashboard
quality_gate_security_idle	baseline	10	Oom killed	Debug Dashboard
quality_gate_security_idle	comparison	10	Oom killed	Debug Dashboard
quality_gate_security_mean_fs_load	comparison	10	Oom killed	Debug Dashboard
quality_gate_security_no_fs_load	baseline	10	Oom killed	Debug Dashboard
quality_gate_security_no_fs_load	comparison	10	Oom killed	Debug Dashboard

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.