pkg/clusteragent/autoscaling/cluster/spot: add Kubernetes events

[AlexanderYastrebov]

What does this PR do?

Motivation

Emit Kubernetes events for scheduler actions so operators can observe spot scheduling decisions via kubectl get events.

Three events are emitted by the Spot Scheduler:

• SpotRebalancingEviction (Warning) on the evicted Pod — emitted each time the rebalancer evicts a pod to converge toward the desired spot/on-demand ratio. Complements the rebalance_evictions metric with a per-pod record that is immediately visible via kubectl, linking the eviction to its cause (excess spot or excess on-demand).

• SpotFallbackEviction (Warning) on the evicted Pod — emitted when a pending spot pod is evicted as part of the on-demand fallback trigger. Without this event, pods evicted during fallback look identical to any other eviction; this event makes the reason explicit and visible per pod, paired with SpotSchedulingDisabled on the workload.

• SpotSchedulingDisabled (Warning) on the Deployment/StatefulSet — emitted once per fallback trigger on the workload object, with the disabled-until timestamp in the message. Allows operators immediately answer "why is this workload running on-demand?" and "when will spot resume?" using only kubectl, without inspecting annotations or logs.

Updates https://datadoghq.atlassian.net/browse/CASCL-1220

Describe how you validated your changes

Tested cluster agent build in the cluster.

Additional Notes

[datadog-official]

🎯 Code Coverage (details)
• Patch Coverage: 62.79%
• Overall Coverage: 51.01% (-0.02%)

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 9170c94 | Docs | Datadog PR Page | Give us feedback!}

[dd-octo-sts]

Files inventory check summary

File checks results against ancestor 6b9abf66:

Results for datadog-agent_7.82.0~devel.git.400.9170c94.pipeline.121324752-1_amd64.deb:

No change detected

[dd-octo-sts]

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 6b9abf6
📊 Static Quality Gates Dashboard
🔗 SQG Job

32 successful checks with minimal change (< 2 KiB)

	Quality gate	Current Size
✅	agent_deb_amd64	747.903 MiB
✅	agent_deb_amd64_fips	703.838 MiB
✅	agent_heroku_amd64	308.689 MiB
✅	agent_rpm_amd64	747.887 MiB
✅	agent_rpm_amd64_fips	703.821 MiB
✅	agent_rpm_arm64	723.412 MiB
✅	agent_rpm_arm64_fips	682.965 MiB
✅	agent_suse_amd64	747.887 MiB
✅	agent_suse_amd64_fips	703.821 MiB
✅	agent_suse_arm64	723.412 MiB
✅	agent_suse_arm64_fips	682.965 MiB
✅	docker_agent_amd64	806.722 MiB
✅	docker_agent_arm64	807.267 MiB
✅	docker_agent_jmx_amd64	997.619 MiB
✅	docker_agent_jmx_arm64	986.816 MiB
✅	docker_cluster_agent_amd64	208.163 MiB
✅	docker_cluster_agent_arm64	221.378 MiB
✅	docker_cws_instrumentation_amd64	7.447 MiB
✅	docker_cws_instrumentation_arm64	6.877 MiB
✅	docker_dogstatsd_amd64	39.028 MiB
✅	docker_dogstatsd_arm64	37.180 MiB
✅	docker_host_profiler_amd64	305.034 MiB
✅	docker_host_profiler_arm64	316.119 MiB
✅	dogstatsd_deb_amd64	29.763 MiB
✅	dogstatsd_deb_arm64	27.818 MiB
✅	dogstatsd_rpm_amd64	29.763 MiB
✅	dogstatsd_suse_amd64	29.763 MiB
✅	iot_agent_deb_amd64	45.695 MiB
✅	iot_agent_deb_arm64	42.410 MiB
✅	iot_agent_deb_armhf	43.195 MiB
✅	iot_agent_rpm_amd64	45.696 MiB
✅	iot_agent_suse_amd64	45.695 MiB

[cit-pr-commenter-54b7da]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 05a1ae3f-4fe8-46e6-b660-73deec6d9c3a

Baseline: 73fc2ca
Comparison: 9170c94
Diff

❌ Experiments with retried target crashes

This is a critical error. One or more replicates failed with a non-zero exit code. These replicates may have been retried. See Replicate Execution Details for more information.

• quality_gate_idle

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_logs	% cpu utilization	+1.62	[+0.53, +2.71]	1	Logs bounds checks dashboard
➖	quality_gate_idle	memory utilization	+0.35	[+0.30, +0.40]	1	Logs bounds checks dashboard
➖	quality_gate_security_idle	memory utilization	+0.33	[+0.26, +0.40]	1	Logs bounds checks dashboard
➖	quality_gate_metrics_logs	memory utilization	+0.06	[-0.19, +0.31]	1	Logs bounds checks dashboard
➖	quality_gate_idle_all_features	memory utilization	-0.00	[-0.05, +0.04]	1	Logs bounds checks dashboard
➖	quality_gate_security_no_fs_load	memory utilization	-0.18	[-0.27, -0.09]	1	Logs bounds checks dashboard
➖	quality_gate_security_mean_fs_load	memory utilization	-0.19	[-0.23, -0.15]	1	Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	observed_value	links
✅	quality_gate_idle	intake_connections	10/10	3 ≤ 4	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	148.06MiB ≤ 154MiB	bounds checks dashboard
✅	quality_gate_idle	total_bytes_received	10/10	580.47KiB ≤ 819.20KiB	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	3 ≤ 4	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	481.62MiB ≤ 495MiB	bounds checks dashboard
✅	quality_gate_idle_all_features	total_bytes_received	10/10	0.89MiB ≤ 1.25MiB	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	4 ≤ 6	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	181.42MiB ≤ 195MiB	bounds checks dashboard
✅	quality_gate_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_logs	total_bytes_received	10/10	264.22MiB ≤ 292MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	339.44 ≤ 2000	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	3 ≤ 6	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	387.00MiB ≤ 430MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_metrics_logs	total_bytes_received	10/10	0.86GiB ≤ 1.04GiB	bounds checks dashboard
✅	quality_gate_security_idle	cpu_usage	10/10	30.06 ≤ 40	bounds checks dashboard
✅	quality_gate_security_idle	memory_usage	10/10	301.78MiB ≤ 330MiB	bounds checks dashboard
✅	quality_gate_security_mean_fs_load	cpu_usage	10/10	61.52 ≤ 80	bounds checks dashboard
✅	quality_gate_security_mean_fs_load	memory_usage	10/10	278.74MiB ≤ 310MiB	bounds checks dashboard
✅	quality_gate_security_no_fs_load	cpu_usage	10/10	22.59 ≤ 40	bounds checks dashboard
✅	quality_gate_security_no_fs_load	memory_usage	10/10	277.90MiB ≤ 320MiB	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

Replicate Execution Details

We run multiple replicates for each experiment/variant. However, we allow replicates to be automatically retried if there are any failures, up to 8 times, at which point the replicate is marked dead and we are unable to run analysis for the entire experiment. We call each of these attempts at running replicates a replicate execution. This section lists all replicate executions that failed due to the target crashing or being oom killed.

Note: In the below tables we bucket failures by experiment, variant, and failure type. For each of these buckets we list out the replicate indexes that failed with an annotation signifying how many times said replicate failed with the given failure mode. In the below example the baseline variant of the experiment named experiment_with_failures had two replicates that failed by oom kills. Replicate 0, which failed 8 executions, and replicate 1 which failed 6 executions, all with the same failure mode.

Experiment	Variant	Replicates	Failure	Logs	Debug Dashboard
experiment_with_failures	baseline	0 (x8) 1 (x6)	Oom killed		Debug Dashboard

The debug dashboard links will take you to a debugging dashboard specifically designed to investigate replicate execution failures.

❌ Retried Normal Replicate Execution Failures (non-profiling)

Experiment	Variant	Replicates	Failure	Debug Dashboard
quality_gate_idle	comparison	1	Oom killed	Debug Dashboard

❌ Retried Profiling Replicate Execution Failures (ddprof)

Note: Profiling replicas may still be executing. See the debug dashboard for up to date status.

Experiment	Variant	Replicates	Failure	Debug Dashboard
quality_gate_idle	comparison	10	Oom killed	Debug Dashboard
quality_gate_idle_all_features	baseline	10	Oom killed	Debug Dashboard
quality_gate_idle_all_features	comparison	10	Oom killed	Debug Dashboard
quality_gate_logs	baseline	10	Oom killed	Debug Dashboard
quality_gate_logs	comparison	10	Oom killed	Debug Dashboard
quality_gate_metrics_logs	baseline	10	Oom killed	Debug Dashboard
quality_gate_metrics_logs	comparison	10	Oom killed	Debug Dashboard
quality_gate_security_idle	comparison	10	Oom killed	Debug Dashboard
quality_gate_security_mean_fs_load	comparison	10	Oom killed	Debug Dashboard
quality_gate_security_no_fs_load	baseline	10	Oom killed	Debug Dashboard

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.

[hmahmood]

Are we already generating events for when a recommendation is applied?

[vboulineau]

You also need to verify/collect these events in kubeapiserver check when unbundle event is true to make sure we show them in DD as well.

[AlexanderYastrebov]

Are we already generating events for when a recommendation is applied?

Yes:

datadog-agent/pkg/clusteragent/autoscaling/cluster/model/const.go

Lines 10 to 21 in 5f7ee54

	const (
	// SuccessfulNodepoolCreateEventReason is the event reason when a nodepool is created successfully
	SuccessfulNodepoolCreateEventReason = "SuccessfulNodepoolCreate"
	// SuccessfulNodepoolUpdateEventReason is the event reason when a nodepool is updated successfully
	SuccessfulNodepoolUpdateEventReason = "SuccessfulNodepoolUpdate"
	// FailedNodepoolUpdateEventReason is the event reason when a nodepool update fails
	FailedNodepoolUpdateEventReason = "FailedNodepoolUpdate"
	// SuccessfulNodepoolDeleteEventReason is the event reason when a nodepool is deleted successfully
	SuccessfulNodepoolDeleteEventReason = "SuccessfulNodepoolDelete"
	// FailedNodepoolDeleteEventReason is the event reason when a nodepool deletion fails
	FailedNodepoolDeleteEventReason = "FailedNodepoolDelete"
	)

added by #45348

[AlexanderYastrebov]

You also need to verify/collect these events in kubeapiserver check when unbundle event is true to make sure we show them in DD as well.

I think I now fixed this, thanks.

[hmahmood]

This should still be "datadog-cluster-autoscaler" no?