Skip to content

fix(tracing): avoid unresolved round symbol #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
e-n-0 wants to merge 1 commit into from
Closed

fix(tracing): avoid unresolved round symbol #367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/datadog/trace_segment.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
#include <array>
#include <cassert>
#include <charconv>
#include <cmath>
#include <string>
#include <unordered_map>
#include <utility>
Expand Down Expand Up @@ -173,9 +172,10 @@ Optional<std::string> resolve_otel_tracestate_value(
}

constexpr std::uint64_t max_value = UINT64_C(1) << 56;
std::uint64_t threshold = static_cast<std::uint64_t>(
std::round((1.0 - decision.configured_rate->value()) *
static_cast<double>(max_value)));
const double threshold_value = (1.0 - decision.configured_rate->value()) *
static_cast<double>(max_value);
// The value is non-negative. Adding 0.5 before truncation rounds it.
std::uint64_t threshold = static_cast<std::uint64_t>(threshold_value + 0.5);
threshold = std::min(threshold, max_value - 1);

std::uint64_t random_value = (~knuth_hash(trace_id.low)) >> 8;
Expand Down
2 changes: 2 additions & 0 deletions test/test_span.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -988,11 +988,13 @@ TEST_SPAN("OpenTelemetry consistent probability sampling") {
};

const auto test_case = GENERATE(values<TestCase>({
{0.0, 1, false, "rv:f0948a54d43b8e;th:ffffffffffffff"},
{0.01, 1, false, "rv:f0948a54d43b8e;th:fd70a3d70a3d7"},
{0.1, 1, true, "rv:f0948a54d43b8e;th:e6666666666668"},
{0.2, 1, true, "rv:f0948a54d43b8e;th:ccccccccccccd"},
{0.5, 1, true, "rv:f0948a54d43b8e;th:8"},
{0.99, 1, true, "rv:f0948a54d43b8e;th:028f5c28f5c29"},
{1.0, 1, true, "rv:f0948a54d43b8e;th:0"},
{0.1, UINT64_C(0x03A93EE8B1999F00), true,
"rv:e6666666666668;th:e6666666666668"},
{0.05, UINT64_C(5401449561355763072), false,
Expand Down
Loading