[FeatureFlags] Replay the configuration handler on registration and bump the OpenFeature package - #9264
Merged
pavlokhrebto merged 2 commits intoSep 18, 2026
Conversation
… OpenFeature package The Remote Configuration subscription is live from module construction, so a payload can land before application code builds a provider and registers a handler. The handler only fired on a change, so a caller waiting on it waited forever. Invoke it at registration when configuration is already held. Bump Datadog.FeatureFlags.OpenFeature to 2.3.1 so the initialization fix can ship: 2.3.0 is already published and immutable.
pavlokhrebto
changed the title
pavlokhrebto
added
type:enhancement
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (9264) and master. ✅ No regressions detected |
BenchmarksBenchmark execution time: 2026-09-17 12:27:21 Comparing candidate commit c4fe818 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 71 metrics, 1 unstable metrics, 64 known flaky benchmarks, 62 flaky benchmarks without significant changes.
|
pavlokhrebto
marked this pull request as ready for review
September 17, 2026 10:21
pavlokhrebto
requested review from
leoromanovsky and
vjfridge
and removed request for
a team
September 17, 2026 10:21
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f1e41ab118
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
andrewlock
reviewed
Sep 17, 2026
leoromanovsky
approved these changes
Sep 17, 2026
leoromanovsky
left a comment
leoromanovsky
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the thorough testing here. Is there a risk of them being flakey?
pavlokhrebto
deleted the
pavlo.khrebto/FFL-2468/ffe-config-replay-and-package-bump
branch
September 18, 2026 08:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
FeatureFlagsModule.RegisterOnNewConfigEventHandlernow invokes the handler immediately when a configuration is already held.Datadog.FeatureFlags.OpenFeaturepackage version 2.3.0 → 2.3.1.Reason for change
The Remote Configuration subscription is live from module construction, which is tracer startup. Application code builds the provider and registers the configuration handler much later. The handler only fired on a change, so a configuration that arrived in that window never reached it, and an application that waits on the handler as its readiness signal waits forever.
Datadog.FeatureFlags.OpenFeature2.3.0 is already published on nuget.org and is immutable. TheInitializeAsyncfix in #9044 rewrites a method that lives in that package, so it cannot reach any customer until the package version moves.Implementation details
Registration reads
_evaluator. A non-null value means a configuration was applied, so the handler is invoked once at registration. The invoke is wrapped in a try/catch that logs a warning, matchingApplyConfiguration: the handler is application code and must not fail the caller.2.3.1 follows the scheme documented in the csproj: the first two digits mirror the referenced OpenFeature version, the third digit is our own patch counter. The
OpenFeaturePackageReferencestays at 2.3.0.Test coverage
Three facts in
FeatureFlagsModuleTests: the handler runs when it registers after a configuration was applied, it does not run when no configuration has arrived, and a throwing handler does not propagate out of registration.Other details
Both changes address FFL-2468. The remaining half of that ticket, the
InitializeAsyncwait, is already on master via #9044. Together with this PR the next release carries the complete fix.