Skip to content

[Debugger] Box value-type keys when indexing IDictionary - #9274

Open
dudikeleti wants to merge 3 commits into
masterfrom
dudik/fix/debugger-dictionary-int-key
Open

[Debugger] Box value-type keys when indexing IDictionary#9274
dudikeleti wants to merge 3 commits into
masterfrom
dudik/fix/debugger-dictionary-int-key

Conversation

@dudikeleti

@dudikeleti dudikeleti commented Sep 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary of changes

  • ProbeExpressionParser.CallGetItem now binds IDictionary.get_Item(object) and boxes value-type keys so Dictionary<int, int>[4] compiles and evaluates.
  • Applies built-in C# implicit conversions for int indexers, while rejecting narrowing conversions such as double or long to int.
  • Preserves null-on-missing behavior for dictionaries with non-nullable value types.
  • String-key dictionary indexing is unchanged.

Reason for change

  • system-tests test_expression_language_hash_operations (DEBUG-2602) failed on Hash5 index 4 with Expression of type System.Int32 cannot be used for parameter of type System.Object of method get_Item(System.Object).
  • The parser classified Dictionary<int, int> as non-generic IDictionary and passed an int key into Expression.Call without boxing.
  • Expression.Call does not automatically apply C# implicit argument conversions.

Implementation details

  • Look up get_Item using typeof(object), matching the IDictionary indexer signature.
  • Apply boxing and built-in implicit conversions required by the selected indexer:
    • Value-type dictionary keys are boxed to object.
    • sbyte, byte, short, ushort, and char list/array indexes are converted to int.
    • Explicit or narrowing conversions, including floating-point and long indexes, remain rejected.
  • Represent non-nullable generic dictionary values as Nullable<TValue> during lookup so IDictionary.get_Item can return null for a missing key without an unboxing exception.
  • Keep the non-generic IDictionary indexer rather than IDictionary<TKey, TValue>: the generic indexer throws KeyNotFoundException for missing keys, while IDictionary.get_Item returns null. Switching would change existing missing-key probe results such as DictionaryKeyNotExist.

Test coverage

  • DebuggerExpressionLanguageTests
    • Existing Dictionary<int, int> key returns its value.
    • Missing Dictionary<int, int> key returns null without an evaluation error.
    • C#-compatible integral list indexes are accepted.
    • Fractional list indexes produce an evaluation error.

Other details

  • Follow-up after this ships: re-enable test_expression_language_hash_operations in system-tests manifests/dotnet.yml.

@pr-commenter

pr-commenter Bot commented Sep 18, 2026 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-09-19 00:53:10

Comparing candidate commit d4b1e49 in PR branch dudik/fix/debugger-dictionary-int-key with baseline commit 773007d in branch master.

📊 Benchmarking dashboard

Found 0 performance improvements and 12 performance regressions! Performance is the same for 60 metrics, 0 unstable metrics, 71 known flaky benchmarks, 55 flaky benchmarks without significant changes.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery net472

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+9.290%; +9.300%]
  • 🟥 throughput [-33030.346op/s; -29112.048op/s] or [-9.303%; -8.199%]

scenario:Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery net6.0

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+8.939%; +8.950%]
  • 🟥 throughput [-40320.323op/s; -28909.655op/s] or [-7.650%; -5.485%]

scenario:Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery netcoreapp3.1

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+9.009%; +9.021%]
  • 🟥 throughput [-37205.511op/s; -29317.875op/s] or [-9.196%; -7.247%]

scenario:Benchmarks.Trace.HttpClientBenchmark.SendAsync net472

  • 🟥 allocated_mem [+296 bytes; +297 bytes] or [+10.196%; +10.207%]
  • 🟥 throughput [-12754.027op/s; -12064.582op/s] or [-14.560%; -13.773%]

scenario:Benchmarks.Trace.HttpClientBenchmark.SendAsync net6.0

  • 🟥 allocated_mem [+191 bytes; +192 bytes] or [+9.052%; +9.064%]

scenario:Benchmarks.Trace.HttpClientBenchmark.SendAsync netcoreapp3.1

  • 🟥 allocated_mem [+191 bytes; +192 bytes] or [+7.267%; +7.279%]
  • 🟥 throughput [-11880.739op/s; -10383.683op/s] or [-9.428%; -8.240%]

scenario:Benchmarks.Trace.NLogBenchmark.EnrichedLog net472

  • 🟥 throughput [-9880.868op/s; -8781.428op/s] or [-7.569%; -6.727%]

Known flaky benchmarks

These benchmarks are marked as flaky and will not trigger a failure. Modify FLAKY_BENCHMARKS_REGEX to control which benchmarks are marked as flaky.

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net472

  • 🟥 throughput [-10667.824op/s; -10177.362op/s] or [-12.649%; -12.067%]

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net6.0

  • 🟥 throughput [-8573.035op/s; -5955.918op/s] or [-7.206%; -5.006%]

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild netcoreapp3.1

  • 🟥 throughput [-11676.486op/s; -10225.187op/s] or [-11.872%; -10.397%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • 🟥 allocated_mem [+1.637KB; +1.637KB] or [+49.731%; +49.747%]
  • 🟥 execution_time [+310.013ms; +312.858ms] or [+153.839%; +155.251%]
  • 🟥 throughput [-58.824op/s; -54.562op/s] or [-10.584%; -9.817%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • 🟥 allocated_mem [+1.013KB; +1.013KB] or [+37.563%; +37.575%]
  • 🟥 execution_time [+375.124ms; +380.587ms] or [+296.371%; +300.687%]
  • 🟩 throughput [+71.541op/s; +73.754op/s] or [+9.432%; +9.724%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟥 allocated_mem [+1.088KB; +1.088KB] or [+40.343%; +40.355%]
  • 🟥 execution_time [+392.710ms; +396.265ms] or [+347.534%; +350.679%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net472

  • 🟥 allocated_mem [+4.749KB; +4.750KB] or [+99.987%; +100.003%]
  • 🟥 throughput [-60364.066op/s; -59978.676op/s] or [-46.966%; -46.666%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net6.0

  • 🟥 allocated_mem [+3.872KB; +3.872KB] or [+81.884%; +81.895%]
  • 🟩 execution_time [-16.262ms; -12.090ms] or [-7.595%; -5.646%]
  • 🟥 throughput [-61003.570op/s; -58230.945op/s] or [-44.529%; -42.505%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody netcoreapp3.1

  • 🟥 allocated_mem [+4.600KB; +4.600KB] or [+99.468%; +99.481%]
  • 🟥 throughput [-49143.781op/s; -46899.095op/s] or [-44.432%; -42.402%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net472

  • 🟥 allocated_mem [+1.372KB; +1.372KB] or [+111.007%; +111.023%]
  • 🟥 throughput [-286863.812op/s; -281152.701op/s] or [-29.290%; -28.707%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net6.0

  • 🟥 allocated_mem [+535 bytes; +536 bytes] or [+43.787%; +43.796%]
  • 🟩 execution_time [-26.897ms; -22.047ms] or [-11.995%; -9.832%]
  • 🟥 throughput [-99432.611op/s; -76217.359op/s] or [-10.623%; -8.142%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody netcoreapp3.1

  • 🟥 allocated_mem [+1.336KB; +1.336KB] or [+110.585%; +110.599%]
  • 🟥 throughput [-171330.654op/s; -155470.049op/s] or [-24.617%; -22.338%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net472

  • 🟥 allocated_mem [+3.378KB; +3.378KB] or [+89.003%; +89.017%]
  • 🟥 throughput [-73067.014op/s; -72264.024op/s] or [-49.173%; -48.633%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net6.0

  • 🟥 allocated_mem [+3.336KB; +3.336KB] or [+88.150%; +88.161%]
  • 🟥 throughput [-74649.032op/s; -71763.042op/s] or [-47.498%; -45.662%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody netcoreapp3.1

  • 🟥 allocated_mem [+3.264KB; +3.264KB] or [+88.493%; +88.506%]
  • 🟥 throughput [-55770.393op/s; -53157.104op/s] or [-44.428%; -42.347%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net6.0

  • 🟩 throughput [+182062.756op/s; +208563.996op/s] or [+6.071%; +6.954%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody netcoreapp3.1

  • 🟩 execution_time [-19.116ms; -14.749ms] or [-8.812%; -6.799%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs net472

  • 🟩 allocated_mem [-13.759KB; -13.757KB] or [-42.326%; -42.318%]
  • 🟥 execution_time [+300.506ms; +301.265ms] or [+150.153%; +150.532%]
  • 🟩 throughput [+1079.255op/s; +1098.028op/s] or [+11.920%; +12.128%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs net6.0

  • 🟩 allocated_mem [-13.722KB; -13.718KB] or [-42.341%; -42.329%]
  • 🟥 execution_time [+300.296ms; +306.209ms] or [+151.440%; +154.422%]
  • 🟩 throughput [+2211.907op/s; +2465.001op/s] or [+16.918%; +18.854%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs netcoreapp3.1

  • 🟩 allocated_mem [-13.722KB; -13.718KB] or [-42.341%; -42.329%]
  • 🟥 execution_time [+300.176ms; +302.534ms] or [+151.205%; +152.393%]
  • 🟩 throughput [+1800.261op/s; +1925.232op/s] or [+17.381%; +18.587%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net472

  • 🟥 execution_time [+296.258ms; +297.147ms] or [+145.510%; +145.947%]
  • 🟩 throughput [+584.220op/s; +595.870op/s] or [+15.488%; +15.797%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net6.0

  • 🟥 execution_time [+298.465ms; +299.731ms] or [+145.909%; +146.527%]
  • 🟩 throughput [+2766.104op/s; +2833.936op/s] or [+40.186%; +41.172%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs netcoreapp3.1

  • 🟥 execution_time [+301.785ms; +302.492ms] or [+150.832%; +151.185%]
  • 🟩 throughput [+1411.063op/s; +1460.341op/s] or [+28.008%; +28.987%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark net472

  • 🟩 execution_time [-146.845µs; -142.703µs] or [-30.149%; -29.299%]
  • 🟩 throughput [+854.925op/s; +883.196op/s] or [+41.639%; +43.016%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark net6.0

  • 🟩 execution_time [-131.911µs; -105.287µs] or [-30.254%; -24.148%]
  • 🟩 throughput [+790.160op/s; +911.468op/s] or [+34.353%; +39.627%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark netcoreapp3.1

  • 🟩 execution_time [-141.818µs; -119.802µs] or [-30.385%; -25.668%]
  • 🟩 throughput [+769.442op/s; +852.668op/s] or [+35.519%; +39.361%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack net472

  • 🟩 execution_time [-127.737µs; -123.167µs] or [-34.488%; -33.254%]
  • 🟩 throughput [+1356.794op/s; +1412.768op/s] or [+50.249%; +52.322%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack net6.0

  • 🟩 execution_time [-98.836µs; -75.199µs] or [-31.553%; -24.007%]
  • 🟩 throughput [+1112.511op/s; +1315.886op/s] or [+34.680%; +41.020%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack netcoreapp3.1

  • 🟩 execution_time [-137.698µs; -115.314µs] or [-37.669%; -31.545%]
  • 🟩 throughput [+1329.190op/s; +1465.862op/s] or [+47.699%; +52.604%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net472

  • 🟥 execution_time [+299.268ms; +300.179ms] or [+149.365%; +149.820%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net6.0

  • 🟥 execution_time [+418.173ms; +424.377ms] or [+454.362%; +461.103%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest netcoreapp3.1

  • 🟥 execution_time [+361.581ms; +368.093ms] or [+274.545%; +279.489%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • 🟥 allocated_mem [+2.822KB; +2.828KB] or [+5.014%; +5.024%]
  • unstable execution_time [+314.658ms; +367.343ms] or [+144.677%; +168.901%]
  • 🟥 throughput [-529.716op/s; -485.582op/s] or [-47.997%; -43.999%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • unstable execution_time [+150.249ms; +296.592ms] or [+64.030%; +126.395%]
  • 🟥 throughput [-675.426op/s; -591.868op/s] or [-45.051%; -39.478%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟥 execution_time [+338.487ms; +348.181ms] or [+202.455%; +208.253%]
  • 🟥 throughput [-395.046op/s; -357.186op/s] or [-27.507%; -24.870%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net6.0

  • 🟩 execution_time [-179.325µs; -144.504µs] or [-9.084%; -7.320%]
  • 🟩 throughput [+41.195op/s; +50.450op/s] or [+8.132%; +9.959%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net472

  • 🟥 allocated_mem [+88 bytes; +89 bytes] or [+11.094%; +11.104%]
  • 🟥 execution_time [+304.419ms; +307.073ms] or [+153.300%; +154.636%]
  • 🟥 throughput [-21636.549op/s; -17938.810op/s] or [-6.962%; -5.772%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net6.0

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+11.101%; +11.112%]
  • unstable execution_time [+299.196ms; +328.712ms] or [+149.928%; +164.718%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch netcoreapp3.1

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+11.101%; +11.112%]
  • 🟥 execution_time [+303.426ms; +308.316ms] or [+152.428%; +154.885%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net472

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+10.235%; +10.247%]
  • 🟥 execution_time [+303.453ms; +305.147ms] or [+152.384%; +153.234%]
  • 🟥 throughput [-18680.344op/s; -17054.836op/s] or [-6.258%; -5.714%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net6.0

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+11.451%; +11.465%]
  • 🟥 execution_time [+299.702ms; +309.045ms] or [+148.189%; +152.809%]
  • 🟥 throughput [-59163.422op/s; -49656.311op/s] or [-9.532%; -8.001%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync netcoreapp3.1

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+10.469%; +10.481%]
  • 🟥 execution_time [+304.376ms; +308.033ms] or [+154.271%; +156.125%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net472

  • 🟥 allocated_mem [+88 bytes; +89 bytes] or [+10.268%; +10.280%]
  • 🟥 execution_time [+301.454ms; +303.294ms] or [+151.303%; +152.226%]
  • 🟥 throughput [-30043.296op/s; -27690.747op/s] or [-7.794%; -7.184%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net6.0

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+9.730%; +9.743%]
  • 🟥 execution_time [+302.066ms; +313.165ms] or [+150.552%; +156.084%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync netcoreapp3.1

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+9.730%; +9.743%]
  • 🟥 execution_time [+300.035ms; +304.863ms] or [+149.265%; +151.667%]
  • 🟥 throughput [-35121.276op/s; -27991.630op/s] or [-8.313%; -6.626%]

scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net472

  • 🟥 allocated_mem [+88 bytes; +89 bytes] or [+5.504%; +5.513%]
  • 🟥 throughput [-19325.026op/s; -17803.323op/s] or [-7.771%; -7.159%]

scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net6.0

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+5.160%; +5.169%]
  • 🟩 execution_time [-15.803ms; -12.140ms] or [-7.349%; -5.645%]

scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog netcoreapp3.1

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+5.136%; +5.148%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net472

  • unstable execution_time [+12.210µs; +60.997µs] or [+3.016%; +15.067%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net6.0

  • 🟩 allocated_mem [-19.723KB; -19.702KB] or [-7.195%; -7.187%]
  • unstable execution_time [-37.807µs; +18.566µs] or [-7.472%; +3.669%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark netcoreapp3.1

  • 🟩 allocated_mem [-16.746KB; -16.729KB] or [-6.105%; -6.098%]
  • unstable execution_time [-77.598µs; -19.599µs] or [-13.447%; -3.396%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net6.0

  • unstable execution_time [+5.959µs; +10.747µs] or [+14.086%; +25.403%]
  • 🟥 throughput [-4757.844op/s; -2867.913op/s] or [-20.029%; -12.073%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark netcoreapp3.1

  • unstable execution_time [-13.074µs; -4.608µs] or [-20.285%; -7.148%]
  • unstable throughput [+1174.684op/s; +2977.192op/s] or [+7.207%; +18.266%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net472

  • 🟥 execution_time [+303.658ms; +305.020ms] or [+153.486%; +154.174%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net6.0

  • 🟥 execution_time [+302.230ms; +304.476ms] or [+153.834%; +154.977%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog netcoreapp3.1

  • 🟥 execution_time [+299.127ms; +301.006ms] or [+149.750%; +150.691%]

scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net472

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+8.432%; +8.443%]
  • 🟥 throughput [-40951.263op/s; -38242.066op/s] or [-11.336%; -10.586%]

scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net6.0

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+8.456%; +8.467%]

scenario:Benchmarks.Trace.RedisBenchmark.SendReceive netcoreapp3.1

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+8.456%; +8.466%]
  • 🟥 throughput [-37531.927op/s; -28820.150op/s] or [-8.883%; -6.821%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net472

  • 🟥 execution_time [+297.568ms; +299.419ms] or [+148.311%; +149.233%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net6.0

  • 🟥 allocated_mem [+88 bytes; +88 bytes] or [+5.502%; +5.512%]
  • 🟥 execution_time [+301.811ms; +303.588ms] or [+151.555%; +152.447%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog netcoreapp3.1

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+5.333%; +5.343%]
  • 🟥 execution_time [+302.152ms; +305.063ms] or [+153.232%; +154.708%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net472

  • 🟥 execution_time [+300.295ms; +301.051ms] or [+149.789%; +150.166%]
  • 🟩 throughput [+61040631.056op/s; +61414570.939op/s] or [+44.454%; +44.726%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net6.0

  • 🟥 execution_time [+413.612ms; +419.123ms] or [+514.400%; +521.254%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore netcoreapp3.1

  • 🟥 execution_time [+298.307ms; +299.346ms] or [+148.789%; +149.307%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net6.0

  • 🟩 throughput [+58112.205op/s; +68295.396op/s] or [+5.426%; +6.377%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net472

  • 🟥 throughput [-71040.594op/s; -67039.204op/s] or [-6.503%; -6.137%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net6.0

  • 🟩 throughput [+44161.248op/s; +48661.009op/s] or [+8.019%; +8.836%]

scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net472

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+14.421%; +14.433%]
  • 🟥 throughput [-87828.306op/s; -83853.489op/s] or [-12.854%; -12.272%]

scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net6.0

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+13.576%; +13.589%]

scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin netcoreapp3.1

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+13.576%; +13.587%]
  • 🟥 throughput [-72800.408op/s; -58373.228op/s] or [-10.165%; -8.150%]

Known flaky benchmarks without significant changes:

  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled netcoreapp3.1
  • scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net6.0
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice netcoreapp3.1
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net6.0
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool netcoreapp3.1
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice netcoreapp3.1
  • scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net472
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net472
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope netcoreapp3.1
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net6.0
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan netcoreapp3.1
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net472
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes netcoreapp3.1

@dd-trace-dotnet-ci-bot

dd-trace-dotnet-ci-bot Bot commented Sep 18, 2026 •
edited
Loading

Copy link
Copy Markdown

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (9274) and master.

✅ No regressions detected

📄 View the full report (charts + all metrics) →

@dudikeleti
dudikeleti marked this pull request as ready for review September 18, 2026 14:53
@dudikeleti
dudikeleti requested a review from a team as a code owner September 18, 2026 14:53
@dudikeleti
dudikeleti requested a review from jpbempel September 18, 2026 14:53
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 18, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-18T14:57:09.181632Z 0d629ad Draft marked ready
🔒 Security Review ✅ Completed 2026-09-18T14:57:40.452647Z 0d629ad Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Sep 18, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0d629ade64

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread tracer/src/Datadog.Trace/Debugger/Expressions/ProbeExpressionParser.Collection.cs Outdated
@dudikeleti
dudikeleti force-pushed the dudik/fix/debugger-dictionary-int-key branch from 0d629ad to 32e242e Compare September 18, 2026 16:19
@dudikeleti
dudikeleti requested a balanced review from Copilot September 18, 2026 16:20
Copilot AI reviewed Sep 18, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Missing value-type dictionary keys can fail during result conversion, and list indexing changes exceed the documented scope.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Updates debugger expression indexing to support value-type dictionary keys.

Changes:

  • Boxes value-type keys for IDictionary indexing.
  • Adds dictionary and numeric list-index tests.
File summaries
File Description
tracer/test/Datadog.Trace.Tests/Debugger/DebuggerExpressionLanguageTests.cs Adds index-expression regression tests.
tracer/src/Datadog.Trace/Debugger/Expressions/ProbeExpressionParser.Collection.cs Converts index arguments for reflected indexers.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 2
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread tracer/src/Datadog.Trace/Debugger/Expressions/ProbeExpressionParser.Collection.cs
Comment thread tracer/src/Datadog.Trace/Debugger/Expressions/ProbeExpressionParser.Collection.cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort, defaults to Balanced
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments
@jpbempel jpbempel jpbempel approved these changes

Assignees

No one assigned

Labels

area:debugger

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dudikeleti @jpbempel