Enable Go thread context sharing across weblogs - #7710
Merged
Merged
Conversation
Contributor
|
|
|
✅ All CI checks and tests passed. 🎉 All green!🧪 All tests passed 🔗 Commit SHA: 7041f30 | Docs | View more details | Give us feedback! |
eliottness
marked this pull request as ready for review
September 14, 2026 13:02
eliottness
requested review from
a team,
Leiyks,
anais-raison and
danielmercier
and removed request for
a team and
Leiyks
September 14, 2026 13:02
Contributor
Author
|
@danielmercier, could you review this follow-up to #7671? I kept your endpoint behavior, moved it into the shared Go package, enabled all tracer-backed Go weblogs, and corrected the activation boundary to |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
RamyElkest
approved these changes
Sep 14, 2026
RomainMuller
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Complete Go system-test coverage for the AppSec trace-ID pprof labels introduced by DataDog/dd-trace-go#5114.
This supersedes #7671 while preserving Daniel Mercier's endpoint implementation. The manifest boundary is corrected to
v2.11.0-devbecause the tracer change is present onrelease-v2.11.x;v2.12.0-devwould incorrectly skip the entire v2.11 release line.Changes
/security/thread_context_sharinginto the shared Gocommonpackage.uds-echoreuses the Echo binary, covering ten weblog variants.THREAD_CONTEXT_SHARINGwithout changing their existing category coverage.Test_ThreadContextSharingglobally for Go fromv2.11.0-dev.apim,envoy, andhaproxyremain excluded because they are proxy-only topologies withbuild_mode: noneand support onlyAPPSEC_BLOCKINGandDEFAULT.Validation
appsecbuild tag, including the nested orchestrion module.go vetacross the shared package and all nine binaries.net-http-span-poolguard.yamlfmt,yamllint, and the targeted CI-orchestrator metadata checks.The complete CWS/eBPF correlation still requires the privileged Linux CI scenario.
Reviewer checklist
utils/.Support: #apm-shared-testing