test(appsec): require Go block failure tag - #7712
Draft
RomainMuller wants to merge 1 commit into
Draft
Conversation
Require the `block_failure` telemetry tag for Go tracer versions from `v2.12.0-dev.1`. This validates that `waf.requests` reports normal requests with `block_failure:false`.
Contributor
|
|
9 tasks
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Validate the Go tracer's
block_failuretag onappsec.waf.requeststelemetry metrics. This corresponds to the tracer work in
DataDog/dd-trace-go#5377.
Changes
Require the existing
waf.requestsmandatory telemetry tags, includingblock_failure, for Go tracer versions fromv2.12.0-dev.1.Local validation
Built the Go
net-httpweblog from the localdd-trace-gocheckout forDataDog/dd-trace-go#5377 and ran:
The test passed. The checkout reports
v2.12.0-dev, so the local run usedthat equivalent threshold before restoring the committed
v2.12.0-dev.1activation version.Reviewer checklist
tests/are modified.