fix(otlp): disable native stats in absent header test - #7713
Merged
Merged
Conversation
Contributor
|
|
🎉 All green!🧪 All tests passed 🔗 Commit SHA: b06a1bb | Docs | View more details | Give us feedback! |
VianneyRuhlmann
marked this pull request as ready for review
September 14, 2026 12:32
VianneyRuhlmann
requested review from
eliottness and
mabdinur
and
a lite review from Copilot
and removed request for
a team and
eliottness
September 14, 2026 12:32
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The test-only change is focused and has no unresolved issues.
Pull request overview
Updates the OTLP absent-header test to isolate disabled metrics behavior from native stats defaults.
Changes:
- Disables native stats computation in the test environment.
File summaries
| File | Summary |
|---|---|
tests/parametric/test_otlp_trace_metrics.py |
Adjusts the absent-header test configuration. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
mabdinur
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Test is failling with client-side stats enable by default.
Changes
Disable client-side stats in the test
Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present