Conversation
Co-authored-by: nccatoni <222672590+nccatoni@users.noreply.github.com>
|
I can only run on private repositories. |
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
AWS SSI runs can fail intermittently when EC2 has no capacity for the requested instance type in the randomly selected availability zone. This was observed for AlmaLinux 8 arm64 with
t4g.mediumcapacity inus-east-1c, forcing an expensive full CI retry even when capacity is available in another configured zone.Changes
InsufficientInstanceCapacity, retry the Pulumi update with each remaining subnet at most once.IdempotentParameterMismatchand keep exhausted capacity errors classified for the existing CI retry fallback.Testing
DD_SITE=datadoghq.com venv/bin/python -m pytest --confcutdir=tests/test_the_test tests/test_the_test/test_aws_provider.py -q: 4 passed.DD_SITE=datadoghq.com ./format.sh --checkpassed mypy, Ruff, whitespace, yamlfmt, yamllint, manifest validation, AI Guard fixture validation, and shellcheck. The final Node.js linter image pull could not run because the sandbox proxy returned Bad Gateway for Docker Hub.Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is presentPR by Bits - View session in Datadog
Comment @DataDog to request changes