Conversation
Co-authored-by: nccatoni <222672590+nccatoni@users.noreply.github.com>
Co-authored-by: nccatoni <222672590+nccatoni@users.noreply.github.com>
|
I can only run on private repositories. |
|
|
|
✅ All CI checks and tests passed. 🎉 All green!🧪 All tests passed 🔗 Commit SHA: 35af397 | Docs | View more details | Give us feedback! |
Co-authored-by: nccatoni <222672590+nccatoni@users.noreply.github.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e1e37ed33d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ) | ||
|
|
||
|
|
||
| def test_update_agent_version_updates_both_ssi_pins(tmp_path: Path) -> None: |
There was a problem hiding this comment.
Assign updater tests to TEST_THE_TEST
This module has no @scenarios.test_the_test marker on this or any other test. The collection hook assigns unmarked items to DEFAULT, while the repository-internals workflow runs ./run.sh TEST_THE_TEST, so all of this new updater coverage is deselected from its normal CI check. Add the TEST_THE_TEST scenario marker to these tests. .cursor/rules/test_the_test.mdcL7-L9
Useful? React with 👍 / 👎.
| def latest_agent_version(root: Path, env: Mapping[str, str] | None = None) -> str: | ||
| result = run_command( | ||
| root, | ||
| ["gh", "api", "repos/DataDog/datadog-agent/releases/latest", "--jq", ".tag_name"], |
There was a problem hiding this comment.
Filter release discovery to Agent 7
The repository-wide /releases/latest endpoint is not major-version aware, so this does not reliably implement a latest-Agent-7 lookup. Once DataDog/datadog-agent marks an 8.x stable release as latest while 7.x is still maintained, normalize_version will raise before inspecting any 7.x release and the nightly job will stop updating these Agent 7 pins. Query the release list and select the newest stable tag matching 7.x instead.
Useful? React with 👍 / 👎.
| try: | ||
| return automate_update(root, version, github_env) | ||
| finally: | ||
| run_command(root, ["dd-octo-sts", "revoke", "-t", token]) |
There was a problem hiding this comment.
Prevent revocation failures from logging the token
If dd-octo-sts revoke exits nonzero, run_command raises an uncaught CalledProcessError whose message includes the complete argument list, including the write-scoped GitHub token passed after -t. This exposes the token in the GitLab job log precisely when revocation failed and the credential may remain usable; handle revocation errors without propagating the secret-bearing command or otherwise redact the token before logging.
Useful? React with 👍 / 👎.
Co-authored-by: nccatoni <222672590+nccatoni@users.noreply.github.com>
Motivation
SSI tests intentionally pin the Datadog Agent to protect tracer pipelines from incompatible or faulty releases, but the pin currently requires manual maintenance. A daily, checks-gated update keeps the tested Agent current without reintroducing the risk of an unvalidated latest-version dependency.
Changes
Testing
TEST_THE_TEST.TEST_THE_TESTrun reached 191 passing tests before this environment's unavailable Docker daemon stopped unrelated Docker-dependent tests; the full formatter likewise only stopped when Docker Hub was unavailable for Node.js lint.Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is presentPR by Bits - View session in Datadog
Comment @DataDog to request changes