Conversation
Co-authored-by: nccatoni <222672590+nccatoni@users.noreply.github.com>
|
I can only run on private repositories. |
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Tracer SSI pipelines currently test custom library packages with the latest injector unless callers coordinate an injector override themselves. That can expose tracer validation to an injector release before it has been deliberately promoted. APMSP-3754 establishes a repository-owned injector pin that DataDog/auto_inject can advance after successful default-branch OCI publication.
Changes
When
DD_INSTALLER_LIBRARY_VERSIONis set, SSI framework entry points load the trimmed version fromauto_inject.lockand export it asDD_INSTALLER_INJECTOR_VERSION. The same rule is applied to Docker SSI, AWS VM SSI, AWS container-app SSI, and generated external pipelines. Default SSI runs remain unchanged when no custom library version is present.The lock contains one immutable package version followed by a newline so automated updates remain a minimal one-line change.
Testing
pytest --scenario TEST_THE_TEST -q tests/test_the_test/test_installer_versions.py tests/test_the_test/test_external_gitlab_pipeline.py tests/test_the_test/test_gitlab_pipeline_structure.py— 11 passed.yamlfmtbinary through the sandbox's blocked network tunnel; no YAML is changed by this PR.Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is presentPR by Bits - View session in Datadog
Comment @DataDog to request changes