ChangeMousePos signature changed to return bool + out parameter - #183
Merged
Conversation
…ool and have an out parameter for new mouse position. The old ChangeMousePos signature was deprecated but still exists. (Marked as Obsolete) Refactor: GameloopExamples.cs ChangeMousePos override changed to new signature. Refactor: GameGameloop.cs now uses new ChangeMousePos signature to only move the mouse cursor when actually requested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
GameVirtualChangeMousePossignature was changed to return a bool and have an out parameter for the new mouse position. The old ChangeMousePos signature was deprecated but still exists. (Marked as Obsolete)The
GameloopExamplesChangeMousePosoverride was changed to the new signature.GameGameloopnow uses the newChangeMousePossignature to only move the mouse cursor when actually requested.Before the mouse cursor was always moved to the current mouse position even if the entire system was not used. This resulted in many subtle problems (fixed by #180) because of rounding errors and other issues. The new system makes sure to only set the mouse position through raylib when ChangeMousePos actually changed the mouse position.