Skip to content

Retire Classic UI and unify flamegraph/API contracts - #88

Merged
reiase merged 2 commits into
masterfrom
cleanup/retire-classic-ui-and-api-ssot
Aug 7, 2026
Merged

Retire Classic UI and unify flamegraph/API contracts#88
reiase merged 2 commits into
masterfrom
cleanup/retire-classic-ui-and-api-ssot

Conversation

@reiase

@reiase reiase commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Retire the Classic web shell (app.rs / pages/ / ui_version); main.rs mounts Next only, with dead Classic helpers and unused imports cleaned so WASM builds warn-free.
  • Move distributed flamegraphs behind extension SSOT (/apis/pprofextension/.../distributed/json, /apis/torchextension/.../distributed/json); remove training public aliases and stop server/training.rs from calling probing_python::features::*.
  • Point the Web PyTorch profile client at /apis/pythonext/pytorch/profile/start; mark removed paths in api_spec.json deprecated_paths with status: removed.
  • Align modularity/contributing/skills docs with reality (cdylib cli_main in root src/lib.rs; content SSOT at python/probing/bundled_skills/); stub architecture.zh.md; archive root REVIEW*.md.

Breaking changes

  • Removed public routes: /apis/training/distributed_flamegraph/json, /apis/training/distributed_stack_flamegraph/json (use extension paths above).
  • Classic UI URLs / Classic↔Next switch are gone; unknown routes fall through to Next Explore.

Test plan

  • cd web && cargo check --target wasm32-unknown-unknown (expect 0 warnings)
  • cd web && cargo test --bins (120 tests)
  • pytest tests/regression/spec/ tests/regression/profiling/test_distributed_flamegraph.py -q
  • cargo test -p probing-rust-regression --test server_training_observability --test python_distributed_flamegraph
  • cd web && dx bundle --release --debug-symbols false
  • Smoke: Next shell loads; Stacks → Distributed; ⌘K eval; Investigate pending actions from source bridge

Made with Cursor

reiase and others added 2 commits August 7, 2026 09:00
Make Next the sole web shell, route distributed flamegraphs through profiler extensions instead of training public handlers, and align modularity/skills docs with the cdylib and bundled_skills SSOT.

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@reiase
reiase force-pushed the cleanup/retire-classic-ui-and-api-ssot branch from 53c52b8 to ef7bbb2 Compare August 7, 2026 01:02
@codecov

codecov Bot commented Aug 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
...egression/profiling/test_distributed_flamegraph.py 94.04% <100.00%> (+0.14%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@reiase
reiase merged commit 97f0944 into master Aug 7, 2026
17 of 18 checks passed
@reiase
reiase deleted the cleanup/retire-classic-ui-and-api-ssot branch August 7, 2026 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant