Retire Classic UI and unify flamegraph/API contracts - #88
Merged
Conversation
Make Next the sole web shell, route distributed flamegraphs through profiler extensions instead of training public handlers, and align modularity/skills docs with the cdylib and bundled_skills SSOT. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
reiase
force-pushed
the
cleanup/retire-classic-ui-and-api-ssot
branch
from
August 7, 2026 01:02
53c52b8 to
ef7bbb2
Compare
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
app.rs/pages//ui_version);main.rsmounts Next only, with dead Classic helpers and unused imports cleaned so WASM builds warn-free./apis/pprofextension/.../distributed/json,/apis/torchextension/.../distributed/json); remove training public aliases and stopserver/training.rsfrom callingprobing_python::features::*./apis/pythonext/pytorch/profile/start; mark removed paths inapi_spec.jsondeprecated_pathswithstatus: removed.cli_mainin rootsrc/lib.rs; content SSOT atpython/probing/bundled_skills/); stubarchitecture.zh.md; archive rootREVIEW*.md.Breaking changes
/apis/training/distributed_flamegraph/json,/apis/training/distributed_stack_flamegraph/json(use extension paths above).Test plan
cd web && cargo check --target wasm32-unknown-unknown(expect 0 warnings)cd web && cargo test --bins(120 tests)pytest tests/regression/spec/ tests/regression/profiling/test_distributed_flamegraph.py -qcargo test -p probing-rust-regression --test server_training_observability --test python_distributed_flamegraphcd web && dx bundle --release --debug-symbols falseMade with Cursor