build(ci): ignore unreachable transitive starlette CVEs (trivy + pip-audit)#130
Merged
Conversation
spashii
enabled auto-merge
June 24, 2026 14:56
…audit) A trivy DB update started flagging starlette 0.52.1 with HIGH CVEs, and pip-audit independently flags the same package by its GHSA IDs — failing the container scan AND the Python CVE scan on every PR, blocking the merge queue. starlette is a transitive dep of google-adk's FastAPI dev-server; Sam imports no starlette and exposes no ASGI app (its HTTP surface is aiohttp). Both CVE paths are unreachable. A direct bump is blocked by google-adk 1.34.0's starlette<1 cap, so ignore in both scanners with rationale (matching the existing PYSEC-2026-161 starlette entry). Re-evaluate when google-adk bumps. .trivyignore += CVE-2026-48818, CVE-2026-54283 .pipauditignore += GHSA-wqp7-x3pw-xc5r, -x746-7m8f-x49c, -82w8-qh3p-5jfq, -jp82-jpqv-5vv3 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
spashii
force-pushed
the
sam/trivyignore-starlette-cves
branch
from
June 24, 2026 15:00
1e1e2bb to
9a0ddef
Compare
spashii
changed the title
spashii
disabled auto-merge
June 28, 2026 18:14
spashii
added a commit
that referenced
this pull request
Jul 14, 2026
…oot CVE (#143) ## What broke Every PR branch went CI-red yesterday (#138–#142 all fail the trivy step; the older green PRs just ran their checks before the CVEs published). Two causes: 1. **curl CVE-2026-5773 / CVE-2026-6276** — Debian shipped the fix (`deb13u4`) but the image stays on `deb13u3`: `apt-get upgrade -y` only runs at layer-build time, and `cache-from: type=gha` keeps serving the cached apt layer. The dockerfile's own comment history (gh CVE-2026-48501) shows this trap has bitten before. 2. **CVE-2026-39822** — Go stdlib `os.Root` symlink following inside `/usr/bin/gh` (built with Go 1.26.4, fixed in 1.26.5). Same family as the eight gh Go-stdlib CVEs already in `.trivyignore`; Sam runs gh against repos it cloned itself, not attacker-controlled trees. ## The fix - New `USER root → apt-get update && upgrade → USER sam` layer **below the source COPY**, so it busts on every commit build and picks up security patches, while the expensive layers above stay cached. Known edge documented in the comment: re-running CI on a bit-identical branch still hits the cache; merging main forces the refresh. - `CVE-2026-39822` added to the gh block in `.trivyignore` with rationale. ## Merge order **Merge this first**, then update the red branches from main (#138, #139, #140, #141, #142) — same unblock shape as June's #130. Found during the 2026-07-14 follow-up to the monthly maintenance pass. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: sam-dembrane <sam-dembrane@sam2ks-MacBook-Pro.local> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
CVE-2026-48818andCVE-2026-54283(starlette HIGH) to.trivyignorewith rationale.Why
A trivy DB update started flagging
starlette 0.52.1with two HIGH CVEs, failing the container scan on every open PR — including docs-only PRs (#124, #125, #127, #128) and blocking the merge queue entirely.starletteis a transitive dependency (viagoogle-adk's optional FastAPI dev-server). Sam imports no starlette and exposes no ASGI/FastAPI app — its only HTTP surface (/healthz,/github/webhook) runs on aiohttp, and the GitHub edge proxy is a separate Cloud Function. Both CVE paths (StaticFiles SSRF; starlette request handling) are unreachable.A direct bump isn't clean: starlette is capped by
google-adk 1.34.0's fastapi pin. Ignored with rationale (same pattern as the existinggh/krb5 entries); to be dropped whengoogle-adkbumps its floor.Unblocks
All 6 stuck PRs, and the next deploy of
mainto Cloud Run.