Skip to content

fixup: build non-dsp nix on tags as well#550

Merged
edolstra merged 1 commit into
mainfrom
fixup-ci
Jul 8, 2026
Merged

fixup: build non-dsp nix on tags as well#550
edolstra merged 1 commit into
mainfrom
fixup-ci

Conversation

@cole-h

@cole-h cole-h commented Jul 8, 2026

Copy link
Copy Markdown
Member

Motivation

Context

Summary by CodeRabbit

  • Chores
    • Updated CI triggers to run from the main branch.
    • Expanded coverage for select “no_dsp” build jobs so they also run for merge queues and tagged releases, improving build consistency.

@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Updates the CI workflow's push trigger branch from master to main, and broadens the conditional execution of three no_dsp build jobs to also run on merge queue events and tag refs, in addition to external fork pull requests.

Changes

CI Workflow Trigger and Condition Updates

Layer / File(s) Summary
Branch trigger and job execution conditions
.github/workflows/ci.yml
Push trigger branch changed from master to main; if conditions for build_x86_64-linux_no_dsp, build_aarch64-linux_no_dsp, and build_aarch64-darwin_no_dsp broadened to include merge_group events and tag refs alongside external fork pull requests.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Suggested reviewers: edolstra

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: running non-dsp builds on tag-based workflows.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fixup-ci

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

@github-actions github-actions Bot temporarily deployed to pull request July 8, 2026 19:23 Inactive

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
.github/workflows/ci.yml (1)

7-10: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Add on.push.tags to this workflow

.github/workflows/ci.yml only matches push to main; tag pushes won’t trigger the workflow, so the startsWith(github.ref, 'refs/tags/') job gates never run for release tags. Add a tags filter if tags are meant to build here.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/ci.yml around lines 7 - 10, The ci workflow currently only
triggers on push to main, so release tag pushes never reach the jobs that check
startsWith(github.ref, 'refs/tags/'). Update the workflow’s on.push
configuration in .github/workflows/ci.yml to include a tags filter alongside the
existing branch trigger, using the same workflow entry points so tag-based
releases also run the CI jobs.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In @.github/workflows/ci.yml:
- Around line 7-10: The ci workflow currently only triggers on push to main, so
release tag pushes never reach the jobs that check startsWith(github.ref,
'refs/tags/'). Update the workflow’s on.push configuration in
.github/workflows/ci.yml to include a tags filter alongside the existing branch
trigger, using the same workflow entry points so tag-based releases also run the
CI jobs.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 58334e64-0506-4c68-8687-186b9ebfd7c6

📥 Commits

Reviewing files that changed from the base of the PR and between 3dc7454 and c99562a.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml

@edolstra edolstra added this pull request to the merge queue Jul 8, 2026
Merged via the queue into main with commit 93b7803 Jul 8, 2026
33 checks passed
@edolstra edolstra deleted the fixup-ci branch July 8, 2026 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants