Conversation
Changed footer to ccontain /sla
Aleksandergreg
approved these changes
Jun 24, 2025
|
Here's the code health analysis summary for commits Analysis Summary
|
WalkthroughThe footer section of the layout template was updated to include a new "SLA" hyperlink pointing to "/sla", placed immediately after the existing "About" link. No other parts of the layout or control flow were changed. Changes
Possibly related PRs
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
sinatra/views/layout.erb (1)
44-45: Confirm/slaroute and add an explicit spacer for consistent footer layout
- Please ensure the application actually defines and mounts a
GET /slaroute; otherwise the new link will 404.- In previous footer markup the single link didn’t need a separator, but now two adjacent
<a>tags rely on the newline to render a space. This is brittle (HTML minifiers or ERB trimming could collapse it). Add an explicit separator (e.g., | ) or wrap links in a list for consistent spacing across environments.- <a href="/about">About</a> - <a href="/sla">SLA</a> + <a href="/about">About</a> | <a href="/sla">SLA</a>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changed footer to also show SLA, as the users didn't have any way of reaching this endpoint, but by typing it manually.
Related Issue:
Fixes #197
Type of Change
How Has This Been Tested?
It has been ran locally in our Docker.dev enviroment, to ensure that the link works properly.
Checklist
Before creating this pull request, please ensure that your code meets the following requirements:
Summary by CodeRabbit