refactor(users): repository pattern, service docs, admin IP whitelist, cleanup - #565
Merged
ayshadogo merged 1 commit intoAug 25, 2026
Conversation
…nd cleanup - Introduce UsersRepository and delegate persistence from UsersService (closes Dfunder#561) - Add JSDoc to the users service/repository documenting params and return types (closes Dfunder#562) - Add IpWhitelistGuard for admin endpoints with ADMIN_IP_WHITELIST config and docs (closes Dfunder#553) - Remove unused duplicate 'dto copy' files (closes Dfunder#554)
|
@zakariyaufarida5-wq Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements four tasks with small, focused changes.
UsersRepositoryand delegate all persistence fromUsersServiceto it, keeping Prisma access in one place and improving testability. Closes Implement Repository Pattern #561IpWhitelistGuardapplied to the admin controller, configurable viaADMIN_IP_WHITELIST(opt-in; allows all when unset), plusdocs/security/admin-ip-whitelist.md. Closes Add IP Whitelisting for Admin Endpoints #553src/auth/dto copy/files. Closes Remove Unused Imports and Dependencies #554Closes #553
Closes #554
Closes #561
Closes #562