feat: implement escrow partial release, portfolio analytics, team collaboration, review moderation & appeal - #696
Open
A6dulmalik wants to merge 2 commits into
Open
Conversation
|
@A6dulmalik Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
…#604 - Dfunder#601: Escrow partial release for milestone-based work - Add EscrowMilestone type with percentage/fixed amount support - add_milestone, approve_milestone_release, release_milestone, auto_release_milestone, get_milestones entry points - PartiallyReleased status + released_amount tracking on EscrowRecord - Partial release tests in escrow/src/partial_release_tests.rs - Dfunder#602: Portfolio analytics contract (contracts/analytics/) - Track earnings by category/client - Project completion rate tracking - Response time analytics - Client satisfaction trends - Earnings predictions - Dfunder#603: Team collaboration features on CommissionAgreement - add_team_member, remove_team_member, update_team_member_role - Role-based access: Lead / Contributor / Viewer - Payment split configuration (set_payment_split / get_payment_split) - Team collaboration tests in commission_agreement/src/team_tests.rs - Dfunder#604: Review moderation & appeal system on Reputation contract - report_review with admin moderation queue - submit_appeal / resolve_appeal / escalate_appeal - Moderation decision history per review - Full test suite in reputation/src/moderation_appeal_tests.rs Also registers analytics, reputation, search, verification contracts in workspace Cargo.toml and fixes Copy derives required by soroban-sdk contracttype macro across shared, verification, reputation, commission_agreement, and search contracts.
- Cargo.toml: keep only contracts that exist in this repo - escrow/errors.rs: merge upstream ContractPaused=13, InvalidSplit=14 with our milestone errors (15-18); all discriminants unique - escrow/storage.rs: keep PartiallyReleased=6 alongside upstream Cancelled=5; keep released_amount field and Milestones DataKey - escrow/lib.rs: add upstream initialize/pause/unpause/cancel_escrow while keeping all milestone partial-release functions (Dfunder#601) - commission_agreement/types.rs: add upstream MilestoneLock, CancellationPolicy, Cancellation, Agency, Roster, RosterEntry, ArtistAgency, AgencyAnalytics DataKey variants alongside our Revision and Team keys - commission_agreement/errors.rs: unique discriminants 1-30, merging upstream (MilestoneLocked=10, InputTooLong=11, DeadlineTooFar=12, cancellation 22-24, agency 25-30) with ours (revision 13-16, team 17-21) - commission_agreement/lib.rs: full merge — upstream create_agreement validation (Dfunder#589, Dfunder#591, Dfunder#592), cancellation (Dfunder#605), agency (Dfunder#609) plus our revision system (Dfunder#600) and team collaboration (Dfunder#603) - Add agency.rs and cancellation.rs from upstream - commission_agreement/Cargo.toml: add legacy_tests feature flag
A6dulmalik
force-pushed
the
feature/issues-601-602-603-604
branch
from
August 26, 2026 22:17
c57fcdb to
5a48645
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements all four issues assigned to a-malik-gh.
Escrow Partial Release for Milestone-Based Work
EscrowMilestonetype withamount,status, andauto_release_ledgerfieldsadd_milestone,approve_milestone_release,release_milestone,auto_release_milestone,get_milestonesPartiallyReleasedcommission status +released_amounttracking onEscrowRecordcontracts/escrow/src/partial_release_tests.rsPortfolio Analytics Contract
contracts/analytics/contracts/analytics/src/test.rsTeam Collaboration Features
add_team_member,remove_team_member,update_team_member_roleonCommissionAgreementContractLead/Contributor/Viewerset_payment_split/get_payment_split— configurable BPS-based payout splitscontracts/commission_agreement/src/team_tests.rsReview Moderation & Appeal System
report_reviewwith automatic admin moderation queue populationsubmit_appeal,resolve_appeal,escalate_appealfor artist/client appealscontracts/reputation/src/moderation_appeal_tests.rsBuild
cargo buildpasses cleanly across all workspace members.Closes #597
Closes #598
Closes #599
Closes #600