Fix rounded fills with outside line numbers - #138
Open
GeronimoCastano wants to merge 6 commits into
Open
Conversation
GeronimoCastano
marked this pull request as draft
August 25, 2026 16:44
GeronimoCastano
marked this pull request as ready for review
August 25, 2026 18:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #134
When line numbers sit outside the code grid, the code fills no longer reach the rounded left edge of the block. The first draft clipped only the first and last rows, which made the left radius depend on the row height. This revision draws outside fills in one rounded container aligned to the code column, matching the whole-block clipping used by inside numbering. The existing stroke behavior is unchanged.
Comparison
The comparison uses the released upstream behavior for Before and this branch's whole-block clipping for After. Both examples use four code lines,
radius: 20pt,number-placement: "outside", and contrasting zebra fills.Tests:
typst compile --root . tests/number-placement/test.typ /tmp/codly-issue-134-whole-clip-test.pdfgit diff --check