Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #780 +/- ##
==========================================
+ Coverage 49.62% 49.76% +0.13%
==========================================
Files 96 96
Lines 10130 10148 +18
Branches 1331 1338 +7
==========================================
+ Hits 5027 5050 +23
+ Misses 4846 4831 -15
- Partials 257 267 +10 🚀 New features to boost your workflow:
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
tieneupin
reviewed
Apr 15, 2026
| db=murfey_db, | ||
| ): | ||
| if SMARTEM_ACTIVE: | ||
| if SMARTEM_ACTIVE and atlas_registration_data.acquisition_uuid is not None: |
Contributor
There was a problem hiding this comment.
When would acquisition_uuid be None in normal operation?
Contributor
Author
There was a problem hiding this comment.
Most of the time! acquisition_uuid will only be set if smartem is active
tieneupin
approved these changes
Apr 15, 2026
Contributor
tieneupin
left a comment
tieneupin
left a comment
There was a problem hiding this comment.
Looks good! Just a question about when the Atlas' acquisition_uuid might end up as None.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we only register EPU grid squares when data collection is started. This sets up a method to register them in all atlases as during screening.
The problem comes on conversion of screening sessions to EPU sessions. Here this loops through all grid squares and changes the tag when the data collection experiment type id is changed.