Skip to content

Retry feedback callback failures caused by no DB rows found #782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tieneupin merged 1 commit into from
Apr 15, 2026
+7 −0
Merged

Retry feedback callback failures caused by no DB rows found #782

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/murfey/server/feedback.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
from sqlalchemy import func
from sqlalchemy.exc import (
InvalidRequestError,
NoResultFound,
OperationalError,
PendingRollbackError,
SQLAlchemyError,
Expand Down Expand Up @@ -2189,6 +2190,12 @@ def feedback_callback(header: dict, message: dict, _db=murfey_db) -> None:
time.sleep(1)
if murfey.server._transport_object:
murfey.server._transport_object.transport.nack(header, requeue=True)
except NoResultFound:
# Missing rows might be due to a race condition and should be requeued
logger.warning("No matching database row was found", exc_info=True)
time.sleep(1)
if murfey.server._transport_object:
murfey.server._transport_object.transport.nack(header, requeue=True)
except Exception:
logger.warning(
"Exception encountered in server RabbitMQ callback", exc_info=True
Expand Down
Loading