feat(web): highlight the devices you hold in the list - #43
Merged
Conversation
A farm is big enough that scanning for your own reservations is the common case, so they sort to the front and carry an accent on the whole card. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The accent on your own reservations was the neutral primary, which reads as "selected" more than "yours". It is now a `--mine` token swapped by a `data-accent` attribute, chosen from the account menu. A browser preference rather than an account column: nothing on the server depends on it, and it rides the pre-paint script and `storage` event the theme already uses — so a popout follows its opener for free. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Measured against the badge fill — the card tinted 15% by the same colour, and the tightest of the three places the token is drawn as text. Amber was 3.15:1 there and every hue but the neutral default fell short of 4.5:1. Dark mode already passed and is unchanged. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The devices list treated a device you hold like any other busy one — you had to
read owner names to find your own reservations. A farm is big enough that
scanning for them is the common case.
beside the status.
Choosing the colour
The highlight is a
--minetoken swapped by adata-accentattribute on<html>, picked from Highlight in the account menu: Default, Blue, Violet,Emerald, Amber, Rose. It is a browser preference rather than an account column —
nothing on the server depends on it, and it rides the pre-paint script and
storageevent the theme already uses, so a popout follows its opener for free.Each accent carries a light value and a lifted dark one. The light values are
set at the lightness that clears 4.5:1 against the badge fill (the card tinted
15% by the same colour), which is the tightest of the three places the token is
drawn as text; dark mode clears AA on its own.
No API change:
device.listalready returnsreservation.userId, and the pagealready knows the current user.
Verified against the fake provider with two devices held by the signed-in user
and one held by another account.
🤖 Generated with Claude Code
highlight_colors.mp4