Skip to content

Support single-dimension image resizing - #5697

Open
Charlie284 wants to merge 2 commits into
DioxusLabs:mainfrom
Charlie284:fix-image-dimensions
Open

Support single-dimension image resizing#5697
Charlie284 wants to merge 2 commits into
DioxusLabs:mainfrom
Charlie284:fix-image-dimensions

Conversation

@Charlie284

Copy link
Copy Markdown

Summary

  • add with_width and with_height image asset options
  • preserve the source aspect ratio when the CLI resizes a single dimension
  • cover width- and height-constrained output dimensions with focused tests

Closes #5458

Testing

  • cargo fmt --all -- --check
  • cargo test -p dioxus-cli opt::image::tests
  • cargo check -p dioxus-cli
  • cargo test -p manganis-core
  • cargo clippy -p dioxus-cli --tests -- -D warnings
  • cargo test --workspace --tests

@Charlie284
Charlie284 marked this pull request as ready for review July 23, 2026 03:59
@Charlie284
Charlie284 requested a review from a team as a code owner July 23, 2026 03:59

@nicoburns nicoburns left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe if you call both .with_width and .with_height it ought to apply Manual?

@Charlie284
Charlie284 requested a review from nicoburns July 24, 2026 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Auto width/height for manganis images

2 participants